Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different orientation of axis labels in image2 #571

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

lmsimp
Copy link
Contributor

@lmsimp lmsimp commented Feb 9, 2022

In this PR I have added two new arguments to image2 to allow users to set the las graphical parameter to change the orientation of axis labels. By default the x-axis labels are now perpendicular to the axes.

previous -
image (1)

new default -
image (2)

@lmsimp
Copy link
Contributor Author

lmsimp commented Feb 9, 2022

Related to the above, I also noticed that the default text sizes for the labels in image2 is. x.cex.axis = .75 and y.cex.axis = .75,. This is fine and imagine a smaller cex is needed as often we have many labels. However, I see that naplot which creates a heat map of missing values using image2, and also renders a barplot above it (as per the above) both have different cex.axis for each y-axis. I'm not sure if this intentional. I tend to think it looks messy. I think perhaps it is best to set the axis labels for the barplot also to .75 so it matches the heatmap?

@lgatto lgatto merged commit 5ddc822 into lgatto:master Feb 23, 2022
@lgatto
Copy link
Owner

lgatto commented Feb 23, 2022

Thanks. Merged, but you are missing a version bump and the NEWS file. Will do it now, but keep an eye on these next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants