Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adjustable default widths and heights #27

Open
lgerhardt45 opened this issue Jun 18, 2020 · 2 comments
Open

Implement adjustable default widths and heights #27

lgerhardt45 opened this issue Jun 18, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@lgerhardt45
Copy link
Owner

I just checked the app and saw that the Done Button on the VideoResultView looks a little lost. Should we maybe give it a default width of let's say 1/2 or 1/3 of the screen width or at least a minimum value? @annalena94 We could also give the Text that comes in (i.e. the label) some padding in general. Would have to check how that looks with all buttons...

image

@annalena94
Copy link
Collaborator

Currently each screen needs to specifically be given a width, we want to implement it as one static variable only stored in one file. I'll figure it out.

@annalena94 annalena94 changed the title Give the DefaultButton a minimum or default width Implement adjustable default widths and heights Jun 20, 2020
@lgerhardt45
Copy link
Owner Author

lgerhardt45 commented Jun 20, 2020

Hey @annalena94, it seems like you can pass the GeometryReader into the subclass, as the geometry instance is a GeometryProxy.
Check out this SO answer
https://stackoverflow.com/a/59084957

and more particularly this link and the responding video to learn about the Geometry reader:
https://www.hackingwithswift.com/books/ios-swiftui/understanding-frames-and-coordinates-inside-geometryreader

Seems like the GeometryReader is a lot more powerful than we thought 😌

@lgerhardt45 lgerhardt45 added the enhancement New feature or request label Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants