-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meson #74
Add meson #74
Conversation
What's the linking error? |
|
What is the exact gcc/g++/ld command line used for linking? |
There was an issue with htslib 1.3.2, but works fine with HEAD. I'll go forward and revert my kseq.h update |
Thanks a lot for the clarification. Nonetheless, I am concerned with adding a new build system that I will not maintain. Once I add new files, meson will keep out of sync until someone else fix it. This seems not ideal. In addition, other developers will want to add autoconf, cmake, ninja... which will make things worse. |
@lh3 Please reconsider this. The whole ecosystem is switching to Meson (and not CMake) from the Autotools, due to it's trivial composability and pluggability. For people that want to reuse minimap2, the current |
The user base of meson seems much smaller than cmake/autoconf right now. I will leave this issue open and revisit at a later time. |
This reverts commit 2bec9dc.
FYI the linking error has gone away because HTSlib no longer uses kseq.h's |
I'll close this. If you want modern build system support, let me know and I can provide it for HEAD. |
Update kseq.h from htslib HEAD. Otherwise we cannot linkminimap2 and htslib at the same time.