Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding over-crabbing is maybe not needed ? #13

Closed
freddieknets opened this issue Mar 6, 2020 · 1 comment
Closed

Avoiding over-crabbing is maybe not needed ? #13

freddieknets opened this issue Mar 6, 2020 · 1 comment
Labels
question Further information is requested

Comments

@freddieknets
Copy link
Contributor

In module_01:
!Avoid crabbing more than the crossing angle
if ( abs(on_crab1)>abs(on_x1) && on_crab1 <> 0) {on_crab1 = abs(on_crab1)/on_crab1 * abs(on_x1);}
if ( abs(on_crab5)>abs(on_x5) && on_crab5 <> 0) {on_crab5 = abs(on_crab5)/on_crab5 * abs(on_x5);}

I discussed with Gianni, and we believe that this limiting is unneeded. The user sets both the crabbing angle and the crossing angle, so he's aware what he's doing (he might even want to simulate over-crabbing on purpose, following the idea that he doesn't know the value of the crossing angle very well).

As an alternative, we might output a warning when over-crabbing.

@freddieknets freddieknets added the question Further information is requested label Mar 6, 2020
@giadarol
Copy link
Contributor

This check was already removed since a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants