Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rewrite] TypeScript types for 1.0 #1402

Closed
spacejack opened this issue Nov 17, 2016 · 7 comments
Closed

[rewrite] TypeScript types for 1.0 #1402

spacejack opened this issue Nov 17, 2016 · 7 comments
Milestone

Comments

@spacejack
Copy link
Contributor

This is a github repo for Mithril 1.0 types that I've been working on (with valuable help and input from a few other mithril devs and users.)

https://github.com/spacejack/mithril.d.ts

It's been working out pretty well for my own projects so far, though I haven't been using the Stream API all that heavily and there are other corners of the API I likely haven't touched, so they could use some additional eyes on them.

@lhorie - was wondering if you would like to include the type definitions in the mithril repo itself. I'd be willing to field issues/PRs for the 1.0 types. (I'm too out of touch with the 0.2 version to address those.)

Alternately, I could submit this to DefinitelyTyped where it would be maintained by the community. MS has made 3rd party types installation process pretty easy (it would be: npm install @types/mithril).

@dead-claudia
Copy link
Member

Whoever does this, remember to file a pull request against DefinitelyTyped's types-2.0 branch.

@lhorie
Copy link
Member

lhorie commented Nov 17, 2016

@spacejack I'd suggest that you submit to DefinitelyTyped if you feel it'll be better maintained there. Personally, I don't use Typescript and I rely almost exclusively on community PRs for TS support

@spacejack
Copy link
Contributor Author

Ok, I'll submit to DefinitelyTyped types-2.0 branch when 1.0 is officially released. In the meantime I'll try to keep it in sync with any API changes. Any other suggestions, testing, feedback is welcome.

@lhorie
Copy link
Member

lhorie commented Nov 18, 2016

I really really really want to lock down the API now so I can actually get a release out of the door :)

@dead-claudia
Copy link
Member

@spacejack I'll note that if you use moduleResolution: "node" (and you generally should with the rewrite), the definitions can remain here.

@lhorie
Copy link
Member

lhorie commented Dec 3, 2016

@spacejack Some updates:

  • background:boolean and withCredentials:boolean were added to m.request
  • m.jsonp now has the same signature as m.request (namely, the first param can be a URL string)

@spacejack
Copy link
Contributor Author

Ok! Thanks for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants