New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized SAT.collides method by precomputing vertex projections #556
Open
bchevalier
wants to merge
52
commits into
liabru:master
Choose a base branch
from
bchevalier:optim-sat-collides-3
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchevalier
force-pushed
the
optim-sat-collides-3
branch
from
January 6, 2018 11:42
183f9fd
to
17862de
Compare
bchevalier
force-pushed
the
optim-sat-collides-3
branch
from
January 6, 2018 12:16
17862de
to
5805d33
Compare
bchevalier
force-pushed
the
optim-sat-collides-3
branch
from
January 7, 2018 04:44
8c84012
to
a6b0521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Projection
Component.projections
property onto bodies that contains the projections of all the body's vertices onto its own axes.Sat._overlapAxes
method in order to benefit from the precomputed projections.Includes #555
Result
Projections
component.SAT.collides
method.Body.update
method.N.B the speed-up of the
SAT.collides
method far outweighs the performance loss of theBody.update
method.Circle Stack: engine performance gain 29.3% (=1.4x)
Before
After
Mixed Shapes: engine performance gain 24.3% (=1.3x)
Before
After