New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization for when no constraint is used #566
base: master
Are you sure you want to change the base?
Conversation
Grid.clear = function(grid, bodies) { | ||
grid.buckets = []; | ||
for (var i = 0; i < bodies.length; i++) { | ||
bodies.pairs.length = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is supposed to be bodies[i].pairs.length = 0
@liabru , Is there any plan for merging this PR ? |
One issue I am facing with this PR is that when a body is added out of bounds Another issue I am seeing is that in After fixing those issues (just |
Optimized out calls to
Constraint
API when no constraint has been defined.Includes #556