Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap use of double variables to float #162

Closed
perigoso opened this issue Mar 24, 2022 · 1 comment · Fixed by #168
Closed

swap use of double variables to float #162

perigoso opened this issue Mar 24, 2022 · 1 comment · Fixed by #168

Comments

@perigoso
Copy link
Contributor

doubles are computationally expensive and most embbeded devices don't have hardware for such computations hurting performance and size, we should use floats

realistically, the only place using double is the average time, which doesn't need that kind of precision anyway?
fperrad added a commit to fperrad/MQTT-C that referenced this issue Jun 4, 2022
@fperrad
refactor with float instead of double
15c70e9 
fix LiamBindle#162
@fperrad fperrad mentioned this issue Jun 4, 2022
Merged
@LiamBindle
Copy link
Owner

Good call! Thanks for raising this.

LiamBindle added a commit that referenced this issue Jun 14, 2022
@LiamBindle
Merge pull request #168 from fperrad/float
0f4c34c 
Refactor with float instead of double. Fixes #162. Courtesy of @fperrad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor with float instead of double fperrad/MQTT-C
2 participants
@LiamBindle @perigoso