Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put all public classes into a namespace to avoid pollution #35

Closed
whoshuu opened this issue Sep 1, 2015 · 1 comment
Closed

Put all public classes into a namespace to avoid pollution #35

whoshuu opened this issue Sep 1, 2015 · 1 comment

Comments

@whoshuu
Copy link
Contributor

whoshuu commented Sep 1, 2015

All of the classes being in the global namespace is probably a no-go for a lot of applications. The right thing to do is to introduce at least one namespace out of respect for those applications.

The most obvious namespace to use is just cpr. If everything is behind that namespace, that should be enough for the most part. Tests can use the normally bad using namespace cpr to avoid onerous changes in that directory.

@whoshuu whoshuu self-assigned this Sep 1, 2015
@whoshuu whoshuu added this to the 1.2 milestone Sep 1, 2015
@whoshuu whoshuu added the Easy label Sep 1, 2015
@whoshuu whoshuu removed their assignment Sep 1, 2015
@whoshuu
Copy link
Contributor Author

whoshuu commented Sep 1, 2015

Labelling this issue as easy since anyone should be able to tackle this. If you're looking to contribute to this library, this would be a super easy, and impactful, place to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant