-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CURL #55
Comments
I've already updated my local curl dependency with your change in f9a3159. I'll close this issue when the upstream curl repo gets updated, and I point my fork to it. Thanks for the information. |
This issue now depends on this pull-request: curl/curl#498 |
The PR have been merged, It is already available in #master branch and will be shipped with v7.46.0 |
Hey @jgsogo, really appreciate the work you've done to push this through. When that version of curl gets shipped and I point my submodule to it, I'll go ahead and close this ticket. |
Thanks @whoshuu |
This can be closed after updating the embedded curl to 7.46.0. |
I have submitted a PR tu bagder/curl (curl/curl#488) with the same content as the one submitted to your fork, now I'm testing whoshuu/cpr#master with bagder/curl#master and everything seems to work ok (Win7 64bits MSVC2015).
I've just had to choose in CMake between
CMAKE_USE_OPENSSL
andCMAKE_USE_SCHANNEL
because under both macros there is the same definition incurl/lib/urldata.h
(line#273 and line#322)Both seems to be "ON" by default... I don't know what the difference is among all the
USE_XXX
macros in that file, but I can confirm that last revision works with CPR (I'll try to run all the tests, but my computer crash with them :S)Update this dependency (after PR merge and tag so install in windows works ok)?
The text was updated successfully, but these errors were encountered: