Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CURL #55

Closed
jgsogo opened this issue Oct 13, 2015 · 6 comments
Closed

Update CURL #55

jgsogo opened this issue Oct 13, 2015 · 6 comments
Assignees
Milestone

Comments

@jgsogo
Copy link

jgsogo commented Oct 13, 2015

I have submitted a PR tu bagder/curl (curl/curl#488) with the same content as the one submitted to your fork, now I'm testing whoshuu/cpr#master with bagder/curl#master and everything seems to work ok (Win7 64bits MSVC2015).

I've just had to choose in CMake between CMAKE_USE_OPENSSL and CMAKE_USE_SCHANNEL because under both macros there is the same definition in curl/lib/urldata.h (line#273 and line#322)

ssl_connect_state connecting_state;

Both seems to be "ON" by default... I don't know what the difference is among all the USE_XXX macros in that file, but I can confirm that last revision works with CPR (I'll try to run all the tests, but my computer crash with them :S)

Update this dependency (after PR merge and tag so install in windows works ok)?

@whoshuu
Copy link
Contributor

whoshuu commented Oct 13, 2015

I've already updated my local curl dependency with your change in f9a3159. I'll close this issue when the upstream curl repo gets updated, and I point my fork to it. Thanks for the information.

@whoshuu whoshuu self-assigned this Oct 13, 2015
@jgsogo
Copy link
Author

jgsogo commented Oct 19, 2015

This issue now depends on this pull-request: curl/curl#498

@jgsogo
Copy link
Author

jgsogo commented Oct 19, 2015

The PR have been merged, It is already available in #master branch and will be shipped with v7.46.0

@whoshuu
Copy link
Contributor

whoshuu commented Oct 21, 2015

Hey @jgsogo, really appreciate the work you've done to push this through. When that version of curl gets shipped and I point my submodule to it, I'll go ahead and close this ticket.

@jgsogo
Copy link
Author

jgsogo commented Oct 21, 2015

Thanks @whoshuu

@whoshuu
Copy link
Contributor

whoshuu commented Dec 10, 2015

This can be closed after updating the embedded curl to 7.46.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants