Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle absolute and relative record.Name's #1

Open
matthiasng opened this issue Oct 15, 2020 · 1 comment
Open

fix: Handle absolute and relative record.Name's #1

matthiasng opened this issue Oct 15, 2020 · 1 comment

Comments

@matthiasng
Copy link
Collaborator

According to this comment, caddy-dns uses FQDN's as record.Name.

Hetzner API on the other side requires a relative record.Names. So depending on if the record.Name is a absolute or relative, we have to remove the Zone from the "record.Name" befor calling the API.

See also: libdns/libdns#12

@mholt
Copy link

mholt commented Oct 15, 2020

Ah yeah, we need to figure out what to do here, the best way to handle this, to give maximum flexibility to each provider implementation. Do you agree with the direction of the linked issue so far?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants