Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharedLibraryLoader subproject #2

Closed
PokeMMO opened this issue Aug 17, 2019 · 2 comments
Closed

SharedLibraryLoader subproject #2

PokeMMO opened this issue Aug 17, 2019 · 2 comments

Comments

@PokeMMO
Copy link
Contributor

PokeMMO commented Aug 17, 2019

Instead of having two implementations SharedLibraryLoader and JniGenSharedLibraryLoader we should probably unify to a single implementation with no other dependencies.

A quick example would be PokeMMO@c9c41d3

This would be a slightly breaking change for libgdx as a whole, which replaces GdxRuntimeExceptions with regular RuntimeExceptions. (Or potentially a new custom typed JnigenRuntimeException)

Would this exception class change be an issue?

Edit: I guess we could also just move GdxRuntimeException to this instead of gdx base. I don't really like that idea, but it would work and not break anything.

@Tom-Ski
Copy link
Member

Tom-Ski commented Sep 19, 2019

A local clone of GdxRuntimeException? Or move it out of gdx core to here?

@MobiDevelop
Copy link
Member

I'd think a new specific runtime exception would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants