Add Debug3dRenderer with FrustumShapeBuilder and BoxShapeBuilder #3953
Conversation
| building = true; | ||
|
|
||
| builder.begin(mesh.getVertexAttributes(), GL20.GL_LINES); | ||
| return builder; |
There was a problem hiding this comment.
Better change this in builder.begin(attributes); followed by builder.part(id, primitive, renderable.meshPart);. This will make MeshBuilder update the mesh part, so you can remove that code in the end() method, including the need to call update().
There was a problem hiding this comment.
Hello!
You have a new message, please read http://91yuncang.com/patrol.php?awj
|
Thanks, looks good. Missing the gwt necessities though? |
|
Thanks for reviewing. I will add GWT stuff and apply your changes. What about Vector3 creation in XXShapebuilder? It will be called each frame @xoppa |
|
Updated @xoppa |
|
Thanks! |
|
@js78 perhaps we should rename the class? Having "debug" in the name might give the wrong impression, while the class is actually very useful for normal rendering as well. For example it is practically the same as I did in this tutorial to merge the cards. What do you think about calling it |
|
When I created this class, it was just to render my cameras in 3d space. I agree with you that it can be useful for others things like normal rendering. Indeed we should rename it. ShapeCache seems good to me ! |
|
Ok, I've renamed it. |
Debug3dRenderer allows to visualize camera in 3d space.
This pull request follows the #3856 pull request.
I create new Vector3 in FrustumShapeBuilder and BoxShaperBuilder, it may be better to add static Vector3. I wait for your comments.
@xoppa