Implements #4360 #4460
Merged
Implements #4360 #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
min < max changed to min <= max, with dim.len2() > 0
|
Am I missing something or would this mean that only zero-size bounding box is considered valid? Shouldn't it be |
|
@Darkyenus You're right, it was a typo. Just fixed it. |
|
Why did you make an exception for at least one axis to be not zero? If a zero volume (3D) is valid and a zero area (2D) is a valid then I guess that a zero length (1D) should be valid as well. |
|
@xoppa I actually had in mind that none of them are to be considered valid, but I guess that's a mistake. Upon further consideration it could be considered valid indeed. |
| @@ -210,7 +210,7 @@ public BoundingBox clr () { | |||
| /** Returns whether this bounding box is valid. This means that {@link #max} is greater than or equal to {@link #min}, with {@link #dim} greater than zero. | |||
There was a problem hiding this comment.
I think you should update comment also.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes BoundingBox compatible with 2D by performing a "greater or equal" comparison between
minandmaxin BoundingBox#isValid().Naturally, this would cause a BoundingBox with an area of 0 to be considered valid, so a
&& !dim.isZero()was added to the expression as well in order to prevent that.EDIT: updated the dim size check