GWT possibility to lazy load assets #5677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/preloader/Preloader.java # backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/preloader/PreloaderBundleGenerator.java
MrStahlfelge
force-pushed
the
gwt_lazyload
branch
from
13cfee7
to
95045c4
Compare
tommyettinger
approved these changes
Aug 29, 2020
There was a problem hiding this comment.
Like the WebAudio PR, this has been tested for years and is known to work. I'm not sure if I could just merge this now? Should I hold off until there are more reviews?
I should mention that I don't currently use an AssetManager, so my review can't really cover any technical details.
|
We don't need to wait for other reviews, but I need to update CHANGES, make a comment on the main Asset manager to note that there is an emu (and compare them for changes) and will transfer the information from the first comment to the wiki. So it's good you waited. :-) |
raeleus
approved these changes
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the idea of #4265, I implemented a solution to skip the GWT preloader if it is not needed.
The preloader prefetches all assets before the game is started. That's useful for all assets that are accessed directly from the render thread and can't get fetched asynchronously, but assets that are loaded via AssetManager don't need to be preloaded.
This PR extends the AssetFilter with a new method that can be overriden to filter assets that don't need to be preloaded, and changes the Preloader to respect this setting and the AssetManager (via AssetLoadingTask) to download the asset if not already done.
To test this, specify an own AssetFilter in your game (as described here) and override the
preload()method. Only returnfalsefor assets that are only loaded via AssetManager and not withAssetManager.finishLoading[Asset]. :)Runnable demo game: Lazy loading version - open the developer network tab, you'll see that the game load its assets on level start.
For those wanting to try or to use this in existing games: you can find Jitpack dependencies to use with libGDX 1.9.8 (working with 1.9.9, too), 1.9.10 and 1.9.11 here.