Add faster ray aabb intersection #6322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgsx-dev
reviewed
Dec 19, 2020
mgsx-dev
reviewed
Dec 19, 2020
|
any copyright/licence for the source you copied from? |
yuripourre
force-pushed
the
faster-ray-aabb
branch
from
bf0e716
to
d4a5844
Compare
|
@mgsx-dev I've just made the changes based on your comments. About the copyright I searched a lot in the book but didn't find anything related to the codes. |
mgsx-dev
requested changes
Dec 19, 2020
|
considering this algo is very close to what we already have in intersectRayOrientedBoundsFast, let say we took inspiration from there ;-). FYI, when there is no licence or copyright notice, it's copyrighted by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed method is borrowed from the book "Real-Time Collision Detection By Christer Ericson".
This algorithm is around 20% faster than the current algorithm.