Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ios delta pause bugfix like on android #6327

Merged
merged 9 commits into from Jan 10, 2021
Merged

Ios delta pause bugfix like on android #6327

merged 9 commits into from Jan 10, 2021

Conversation

Armaxxx
Copy link
Contributor

@Armaxxx Armaxxx commented Dec 22, 2020

Should fix #6093

@MobiDevelop
Copy link
Member

MobiDevelop commented Dec 22, 2020 •
edited

Please use separate branches for separate PRs. Or, rather, don't stack changes from one PR onto another. It could be that this one would be approved without the unrelated changes around zip files.

@Armaxxx
Copy link
Contributor Author

Armaxxx commented Dec 23, 2020

Oh you're completely right, how silly of me, thought I'd branch them before the fact. Will redo the PR.

@Armaxxx
Copy link
Contributor Author

Armaxxx commented Dec 23, 2020

There, sorry for the revert, now this branch only holds the fix.

obigu
obigu requested changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@obigu obigu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Still have no tested it, just some style stuff.

Regarding the code format changes, we usually try to only apply style changes to new code to keep git history and PRs easier to read.

backends/gdx-backend-robovm/src/com/badlogic/gdx/backends/iosrobovm/IOSGraphics.java Outdated Show resolved Hide resolved
backends/gdx-backend-robovm/src/com/badlogic/gdx/backends/iosrobovm/IOSGraphics.java Outdated Show resolved Hide resolved
backends/gdx-backend-robovm/src/com/badlogic/gdx/backends/iosrobovm/IOSGraphics.java Outdated Show resolved Hide resolved
@Armaxxx
Moved resume declaration with the rest of the declarations, moved res…
1bb1654 
…ume true outside of synchronized block, removed redundancy while checking if resume is triggered
@obigu
Copy link
Contributor

obigu commented Dec 31, 2020

Tested, seems to we working, thanks!

MrStahlfelge
MrStahlfelge requested changes Jan 3, 2021
View reviewed changes
Copy link
Member

@MrStahlfelge MrStahlfelge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of unneccesary whitespace changes, please reduce the changes to the necessary ones

@MrStahlfelge MrStahlfelge merged commit b230a88 into libgdx:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrStahlfelge MrStahlfelge MrStahlfelge requested changes

@obigu obigu obigu approved these changes

Assignees
No one assigned
Labels
ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Large delta after pause/resume (iOS)
4 participants
@Armaxxx @MobiDevelop @obigu @MrStahlfelge