-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement loading Tiled Point objects #6384
base: master
Are you sure you want to change the base?
implement loading Tiled Point objects #6384
Conversation
You have to add the libgdx/gdx/res/com/badlogic/gdx.gwt.xml Lines 296 to 303 in 3d1f76f
|
@SimonIT fixed, thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix formatting, indentation seams off. You can use provided formatter, see contribution guidelines.
You also need to update CHANGES file with this API addition.
Apart from these details, it looks good to me.
@@ -300,6 +300,7 @@ | |||
<include name="maps/objects/PolylineMapObject.java"/> | |||
<include name="maps/objects/RectangleMapObject.java"/> | |||
<include name="maps/objects/TextureMapObject.java"/> | |||
<include name="maps/objects/PointMapObject.java"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please fix formatting here as well :-)
I think it's good to have it but considering it's a breaking change without much value for now, i propose to merge it when we will implement some other big changes related to Tiled 1.x (eg. infinite map support, template support) and/or a new major version of libGDX. |
This pull request adds Tiled Point objects (https://doc.mapeditor.org/en/stable/reference/tmx-map-format/#point).
As of now, TmxMapLoader parses points into rectangles with zero width/height. This behavior is probably fine as it is, but one could argue that it's counter-intuitive and non-explicit, so, here we are.
It's also a breaking change for all the people who rely on that their points are parsed into zero-sized rectangles. So, if this PR has any value, I'm open to suggestions on how to work around that.
TiledMapObjectLoadingTest is updated to reflect a new type of objects.