Lwjgl3Net: Fallback to xdg-open on Linux if Desktop.BROWSE is unavailable #6719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able * Desktop.Action.BROWSE is unavailable inside of Linux sandboxes. We're expected to use xdg portals where available
noblemaster
reviewed
Dec 11, 2021
| try { | ||
| Desktop.getDesktop().browse(new URI(uri)); | ||
| return true; | ||
| } catch (Throwable t) { | ||
| return false; | ||
| } | ||
| } else if (SharedLibraryLoader.isLinux) { | ||
| try { | ||
| (new ProcessBuilder("xdg-open", (new URI(uri).toString()))).start(); |
There was a problem hiding this comment.
Maybe new URI(uri).toString() can just be url?
There was a problem hiding this comment.
This appears messy, but it has a purpose. Running the uri through a URI builder sanitizes the input to prevent arbitrary code execution on a client system by other players in online environments.
See #6543 (comment) for details
There was a problem hiding this comment.
That makes sense. Good to keep it!
Quillraven
pushed a commit
to Quillraven/libgdx
that referenced
this pull request
Jan 2, 2022
…able (libgdx#6719) * Desktop.Action.BROWSE is unavailable inside of Linux sandboxes. We're expected to use xdg portals where available
SimonIT
added a commit
that referenced
this pull request
Feb 8, 2023
* (#6480) load parallax factor value from Tiled * (#6480) add parallax layers * (#6480) add parallax render support (first draft) * (#6480) set parallax scrolling factor * (#6480) update parallax rendering * (#6480) use cache boundaries for cached renderer * (#6480) remove unused method * (#6480) update CHANGES * (#6480) remove unused Vector3 * (#6480) fix formatting * (#6480) fix hierarchical scrolling factor loading * (#6480) update parallax rendering (tile and image layer) * (#6480) remove wrong comment * Replace gradle deprecations (#6652) * Upgrade gradle wrapper to 6.9 * Update junit * Replace deprecated compile for dependencies * Replace deprecated archiveName with archiveFileName * Upgrade to gradle 6.9.1 * Replace compile to api in headless * Update gdx-jnigen to 2.2.1 to fix build issues. (#6720) * Add back breaking change notice (#6723)[CI skip] * Update to LWJGL 3.3.0 * Revert "Temporarily comment LWJGL3 macOS ARM64 dependencies" This reverts commit 7ac239c. * Update fetch.xml * fix bad camera reference by using instance variable instead of parameter (#6722) * Javadocs to make it clear Pool doesn't reset if discarding. * Revert "Fixed texture packer legacy output having wrong Y value when using padding." This reverts commit 08cd7fd. Turns out the "fix" was actually a bug! closes #6701 * fix #6618 move vertex array index buffer limit to backends (#6621) * fix #6618 move vertex array index buffer limit to backends * Apply formatter * fix test * Apply formatter Co-authored-by: GitHub Action <action@github.com> * Add missing .gitignore to gdx-bullet * Lwjgl3Net: Fallback to xdg-open on Linux if Desktop.BROWSE is unavailable (#6719) * Desktop.Action.BROWSE is unavailable inside of Linux sandboxes. We're expected to use xdg portals where available * add back default Pool behavior when object is discarded (#6730) * Remove all usage of Arial assets, replace with LSans. (#6727) * Fixes Gradle build issues (GWT Tests, Runnable Tools) (#6731) * Let buildRunnables task depend on build task so all dependencies are present * gwtref: Throw ClassNotFoundException instead of RuntimeException in ReflectionCache.forName (#6718) * gwtref: Throw ClassNotFoundException instead of RuntimeException in ReflectionCache.forName Fixes #6708 * gwt/emu/reflect: Add exception cause in ClassReflection.forName * Gradle publishing support (#6725) * Should match maven for artifacts, including `$NAME-platform` artifacts for jnigen natives. * Clean Up PixmapBlendingTest (#6732) This may fix an unclear issue with PixmapBlendingTest, as well, but in general it makes the code more readable and idiomatic for a libGDX test. * Use gradle for github-actions publishing * javadoc encoding also, remove group from box2d parent * Update build status badge in README * Update freetype to v2.10.4 and use submodule. * Update freetype to v2.11.1 * Populate cppExcludes to prevent build issues in gdx-freetype * More specific cppExcludes to make android happy * Add note about breaking change on legacy LWJGL3 projects. * (#6480) update CHANGES * (#6480) run spotlessApply on changed map files * Modified the math in all map renderers to subtract on the x value to the parallax effect works properly. Modified test maps parallax value so it was easier to see the effect. Made a change in the BaseTmxMapLoader just to keep it consistent with the rest of the code. * Changed OrthoCachedTiledMapRenderer to use negative instead of positive like the rest, also changed using cacheBounds to determine parallax to using viewBounds like the rest. Also modified the ortho map to have a non group parallax layer. so it will show up in OrthoCachetest * Apply formatter --------- Co-authored-by: klausm <simon.klausner@swarovski.com> Co-authored-by: SimonIT <simonit.orig@gmail.com> Co-authored-by: PokeMMO <2398581+PokeMMO@users.noreply.github.com> Co-authored-by: MGSX <germain.aubert@gmail.com> Co-authored-by: Desu <desu@pokemmo.eu> Co-authored-by: Nathan Sweet <nathan.sweet@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Kyu <kyu@pokemmo.eu> Co-authored-by: Tommy Ettinger <tommy.ettinger@gmail.com> Co-authored-by: Justin Shapcott <support@mobidevelop.com> Co-authored-by: Justin Shapcott <justin@mobidevelop.com> Co-authored-by: nojus297 <46261165+nojus297@users.noreply.github.com> Co-authored-by: Yuri Pourre <yuripourre@users.noreply.github.com> Co-authored-by: Tomski <tomwojciechowski@asidik.com> Co-authored-by: BoBIsHere86 <rck86@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a libGDX application inside of a linux sandbox container (Snap/Flatpak), Net#openURI will fail to open any url because the Desktop.BROWSE action is unavailable. This is intended behavior of the sandbox. You're supposed to use xdg-portals to access urls in these environments.
The simplest way to workaround this limitation is to call xdg-open for the target uri. There's no guarantee it'll be able to handle your uri if a mime type is undefined for the sandbox, but it'll work most of the time. This binary is standard on freedesktop platforms.