-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update to gwt 2.10.0 #7250
Conversation
3a59fe5
to
ed2eba8
Compare
# Conflicts: # gradle/dependencies.gradle
Seems the 2.10.0 dtd may be deployed soon(ish)? gwtproject/gwt#9770 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. We should definitely test this as a snapshot before releasing, since I have encountered lots of subtle quirks of GWT before (I'm sure many of us have).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks solid; the DTDs use HTTPS and point to 2.10.0, so that should be fine (it's what I've started changing my projects to use, and none of them have had issues). Approved!
It looks like there's no entry in the changelog. I think I'll merge this first, because it has two approvals, and encourage GWT users to test the latest SNAPSHOT release. If there are any critical issues, then fixing them may affect the changelog; if there aren't any issues, it should be easy to add it in (potentially including quick tips for updating, if we discover some are needed). |
Current Gdx Setup fails when executing |
Ahhh, probably because
is missing. Maybe we can include it with |
Not sure about that, I think we don't do it with any other sources. I'd just add the dep alongside the other sources deps. |
I don't know why there's no dtd for 2.10.0, so I chose the dtd from 2.9.0