Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to gwt 2.10.0 #7250

Merged
merged 3 commits into from
Nov 12, 2023
Merged

Conversation

SimonIT
Copy link
Member

@SimonIT SimonIT commented Oct 6, 2023

I don't know why there's no dtd for 2.10.0, so I chose the dtd from 2.9.0

# Conflicts:
#	gradle/dependencies.gradle
@obigu
Copy link
Contributor

obigu commented Oct 6, 2023

Seems the 2.10.0 dtd may be deployed soon(ish)? gwtproject/gwt#9770

tommyettinger
tommyettinger previously approved these changes Oct 6, 2023
Copy link
Member

@tommyettinger tommyettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should definitely test this as a snapshot before releasing, since I have encountered lots of subtle quirks of GWT before (I'm sure many of us have).

@crykn crykn added this to the 1.12.2 milestone Oct 15, 2023
Copy link
Member

@tommyettinger tommyettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks solid; the DTDs use HTTPS and point to 2.10.0, so that should be fine (it's what I've started changing my projects to use, and none of them have had issues). Approved!

@tommyettinger
Copy link
Member

It looks like there's no entry in the changelog. I think I'll merge this first, because it has two approvals, and encourage GWT users to test the latest SNAPSHOT release. If there are any critical issues, then fixing them may affect the changelog; if there aren't any issues, it should be easy to add it in (potentially including quick tips for updating, if we discover some are needed).

@tommyettinger tommyettinger merged commit 93503b4 into libgdx:master Nov 12, 2023
2 checks passed
@SimonIT SimonIT deleted the chore/gwt-2.10.0 branch November 12, 2023 12:46
@obigu
Copy link
Contributor

obigu commented Nov 14, 2023

Current Gdx Setup fails when executing superDev with several errors like this:
[ERROR] Line 6669: No source code is available for type jsinterop.annotations.JsMethod; did you forget to inherit a required module?
Maybe something missing in the Gdx Setup template app GWT config?

@SimonIT
Copy link
Member Author

SimonIT commented Nov 14, 2023

Ahhh, probably because

"com.google.jsinterop:jsinterop-annotations:${versions.jsinteropAnnotations}:sources"

is missing. Maybe we can include it with sourcesElements so it gets added transitively

@obigu
Copy link
Contributor

obigu commented Nov 14, 2023

transitively

Not sure about that, I think we don't do it with any other sources. I'd just add the dep alongside the other sources deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants