-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump min Android API level to 19 #7310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TargetAPI
is redundant if we're targeting a minimum of 19. It's doing no harm, of course - just an opportunity to remove more lines if you like seeing red.
Other instances: https://github.com/search?q=repo%3Alibgdx%2Flibgdx%20targetapi&type=code
de7e767 - Oh yeah, it should be marked as a breaking change, I figure, as some existing projects won't work unchanged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the bump, api 19 should be more than reasonable.
This feels reasonable at this point. AndroidX moved their minSdkVersion to SDK 19 in October because "According to Play Store check-in data, nearly all Android users have devices on API 19 or newer, so it’s no longer necessary to support legacy versions." https://android-developers.googleblog.com/2023/10/androidx-minsdkversion-19.html |
Fixes #7307