Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min Android API level to 19 #7310

Merged
merged 5 commits into from
Feb 3, 2024
Merged

Bump min Android API level to 19 #7310

merged 5 commits into from
Feb 3, 2024

Conversation

obigu
Copy link
Contributor

@obigu obigu commented Dec 27, 2023

Fixes #7307

Copy link
Contributor

@Frosty-J Frosty-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TargetAPI is redundant if we're targeting a minimum of 19. It's doing no harm, of course - just an opportunity to remove more lines if you like seeing red.

Other instances: https://github.com/search?q=repo%3Alibgdx%2Flibgdx%20targetapi&type=code

@Frosty-J
Copy link
Contributor

de7e767 - Oh yeah, it should be marked as a breaking change, I figure, as some existing projects won't work unchanged.

@obigu obigu added this to the 1.12.2 milestone Dec 28, 2023
Copy link
Contributor

@Berstanio Berstanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the bump, api 19 should be more than reasonable.

@MobiDevelop
Copy link
Member

This feels reasonable at this point. AndroidX moved their minSdkVersion to SDK 19 in October because "According to Play Store check-in data, nearly all Android users have devices on API 19 or newer, so it’s no longer necessary to support legacy versions."

https://android-developers.googleblog.com/2023/10/androidx-minsdkversion-19.html

@obigu obigu merged commit 6ff5855 into libgdx:master Feb 3, 2024
@obigu obigu deleted the api19 branch February 3, 2024 20:57
@obigu obigu mentioned this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNAPSHOT build no longer works on Android 4.1
5 participants