Abstract LibGit2Sharp away in testing context #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nulltoken I pushed a new version of the PR. Basically, I removed the Shameless quote: I just see it as the product of good design, not as a separate feature that requires tests itself. Please tell me if you're ok with that, or if you want me to reintroduce |
|
👍 for me. Thanks for this! |
|
Looks good to me. Any reason we don't apply this to all objects from now on? |
|
Nice @yorah! I'm happy with this too. |
|
@yorah Merged. Very nice job! ❤️ |
|
❤️ thanks everybody! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to #138, and is a follow-up of #182.
Changes:
IRepositoryinterface has been introduced.MockedRepositoryFixture, which shows how to abstract LibGit2sharp in a testing context. If you have a better name for this fixture, please tell!@haacked @nulltoken Would you please be so kind as to review this PR?