Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc 4.x / linux compile fix #30

Closed
josch opened this issue Sep 13, 2015 · 2 comments
Closed

gcc 4.x / linux compile fix #30

josch opened this issue Sep 13, 2015 · 2 comments

Comments

@josch
Copy link
Contributor

josch commented Sep 13, 2015

https://sourceforge.net/p/glui/patches/6/

The current CVS dump of glui doesn't compile under gcc 4.x under linux (mandriva free 2007); basically it chokes on the 'template class ...' in glui.h.

Here's the cvs-diff patch:

===================================================================
RCS file: /cvsroot/glui/glui/src/include/GL/glui.h,v
retrieving revision 1.6
diff -r1.6 glui.h
1715,1716c1715,1721
< template class GLUIAPI std::allocator<GLUI_String>;
< template class GLUIAPI std::vector<GLUI_String, std::allocator<GLUI_String=""> >;

    //
    // (iw, 070225) commented out the 'template'; gcc 4+ won't accept it under linux.
    // (if anybody else needs it under windows or so, feel free to put the reqd ifdefs
    // around it ...
    //
    /* template */ class GLUIAPI std::allocator<GLUI_String>;
    /* template */ class GLUIAPI std::vector<GLUI_String, std::allocator<GLUI_String> >;
@nigels-com
Copy link
Collaborator

Builds fine for me on Ubuntu 14.04, gcc 4.8
gcc 4.4 also seems to work, just fine.

$ CC=gcc-4.4 CXX=g++-4.4 cmake -G 'Unix Makefiles' ..

@josch
Copy link
Contributor Author

josch commented Sep 24, 2015

Jup, works just fine over here as well on Ubuntu 14.04, Debian Jessie, Debian Sid and Windows 7 64bit.

@josch josch closed this as completed Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants