Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed autogenerated gnulib files. #10

Merged
merged 3 commits into from Jun 30, 2014
Merged

Removed autogenerated gnulib files. #10

merged 3 commits into from Jun 30, 2014

Conversation

simait
Copy link
Contributor

@simait simait commented Jun 27, 2014

Leaving these files in the git-repo will break subdir builds, i.e.
the new files will be located in $subdir/gnulib, but the files in
$top_srcdir/gnulib will be used.

make check && make distcheck complete successfully.

These files are already removed by make distclean (and recreated by make), so should be safe to apply, but it's always nice if it's tested on more than one system (Ubuntu 12.04 LTS here).

-- Simon

Removed autogenerated gnulib files.
7a60df1 
Leaving these files in the git-repo will break subdir builds, i.e.
the new files will be located in $subdir/gnulib, but the files in
$top_srcdir/gnulib will be used.
@egli
Copy link
Member

egli commented Jun 27, 2014

Excellent stuff! That's how I like to work with people. Two things:

  • Should these files be added to .gitignore?
  • Can you add your email to the AUTHORS file (I already added your name)?
    Thanks

@simait
Copy link
Contributor Author

simait commented Jun 27, 2014

Thanks!

Adding the files to .gitignore is probably a good idea, I like a clean git status and it'll help deter people from adding them again (the names are a bit deceiving!). Let me know and I'll add them.

I'll push the AUTHORS update in a sec (to this branch).

@egli
Copy link
Member

egli commented Jun 28, 2014

Yes, please add them to the .gitignore. Thanks

@simait
Copy link
Contributor Author

simait commented Jun 28, 2014

Okies, I'll fix it first thing on Monday.

On 28 June 2014 09:07, Christian Egli notifications@github.com wrote:

Yes, please add them to the .gitignore. Thanks

—
Reply to this email directly or view it on GitHub
#10 (comment).

egli added a commit that referenced this pull request Jun 30, 2014
@egli
Merge pull request #10 from IndexBraille/feature/fix-gnulib-subdir-build
15e785f 
Removed autogenerated gnulib files.
@egli egli merged commit 15e785f into liblouis:master Jun 30, 2014
@simait simait deleted the feature/fix-gnulib-subdir-build branch August 29, 2014 08:45
sthibaul added a commit to sthibaul/liblouis that referenced this pull request Mar 25, 2022
@sthibaul
Fix memory leak on table compilation error
456e7b5 
Otherwise we get

/home/samy/brl/translation/liblouis-git/tests/tables/bad.ctb:1: error: opcode 'bad' not defined.
1 errors found.
tests/tables/bad.ctb could not be compiled

=================================================================
==3022215==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 61 byte(s) in 1 object(s) allocated from:
    #0 0x7f67684e0545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75
    liblouis#1 0x7f676831b31a in __GI___strdup string/strdup.c:42
    liblouis#2 0x7f676849d47e in compileFile /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4650
    liblouis#3 0x7f676849d9b1 in compileTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4767
    liblouis#4 0x7f676849e011 in getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4939
    liblouis#5 0x7f676849dcb0 in _lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4848
    liblouis#6 0x7f676849dd0e in lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4860
    liblouis#7 0x7f676849e165 in lou_checkTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4978
    liblouis#8 0x55e477d791c2 in main /home/samy/brl/translation/liblouis-git/tests/checkTable.c:29
    liblouis#9 0x7f67682b47fc in __libc_start_main ../csu/libc-start.c:332
    liblouis#10 0x55e477d79099 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/checkTable+0x1099)

SUMMARY: LeakSanitizer: 61 byte(s) leaked in 1 allocation(s).
FAIL checkTable (exit status: 23)
@sthibaul sthibaul mentioned this pull request Mar 25, 2022
Closed
sthibaul added a commit to sthibaul/liblouis that referenced this pull request Mar 25, 2022
@sthibaul
Fix memory leak on table compilation error
b166bdc 
Otherwise we get

/home/samy/brl/translation/liblouis-git/tests/tables/bad.ctb:1: error: opcode 'bad' not defined.
1 errors found.
tests/tables/bad.ctb could not be compiled

=================================================================
==3022215==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 61 byte(s) in 1 object(s) allocated from:
    #0 0x7f67684e0545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75
    liblouis#1 0x7f676831b31a in __GI___strdup string/strdup.c:42
    liblouis#2 0x7f676849d47e in compileFile /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4650
    liblouis#3 0x7f676849d9b1 in compileTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4767
    liblouis#4 0x7f676849e011 in getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4939
    liblouis#5 0x7f676849dcb0 in _lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4848
    liblouis#6 0x7f676849dd0e in lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4860
    liblouis#7 0x7f676849e165 in lou_checkTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4978
    liblouis#8 0x55e477d791c2 in main /home/samy/brl/translation/liblouis-git/tests/checkTable.c:29
    liblouis#9 0x7f67682b47fc in __libc_start_main ../csu/libc-start.c:332
    liblouis#10 0x55e477d79099 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/checkTable+0x1099)

SUMMARY: LeakSanitizer: 61 byte(s) leaked in 1 allocation(s).
FAIL checkTable (exit status: 23)
sthibaul added a commit to sthibaul/liblouis that referenced this pull request Mar 26, 2022
@sthibaul
SwapTest: Fix read overflow
2ed8aac 
SwapTest has to check wheter it overflows the input. Otherwise we get in
tests/braille-specs/da-dk-g16-lit.log:

==43588==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000026712 at pc 0x7f7d9ff57381 bp 0x7fff050fd170 sp 0x7fff050fd168
READ of size 2 at 0x602000026712 thread T0
    #0 0x7f7d9ff57380 in swapTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:399
    liblouis#1 0x7f7d9ff5d22e in passDoTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:861
    liblouis#2 0x7f7d9ff552f2 in findForPassRule /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:211
    liblouis#3 0x7f7d9ff55ac9 in makeCorrections /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:276
    liblouis#4 0x7f7d9ff6128d in _lou_translate /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:1272
    liblouis#5 0x55b837c9bdac in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:180
    liblouis#6 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807
    liblouis#7 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869
    liblouis#8 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063
    liblouis#9 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332
    liblouis#10 0x55b837c914c9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tools/.libs/lou_checkyaml+0x64c9)

0x602000026712 is located 0 bytes to the right of 2-byte region [0x602000026710,0x602000026712)
allocated by thread T0 here:
    #0 0x7f7da00777cf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
    liblouis#1 0x55b837c9b8b6 in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:138
    liblouis#2 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807
    liblouis#3 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869
    liblouis#4 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063
    liblouis#5 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332
@sthibaul sthibaul mentioned this pull request Mar 26, 2022
Closed
bertfrees pushed a commit that referenced this pull request Mar 28, 2022
@sthibaul @bertfrees
Fix memory leak on table compilation error
22b2ae1 
Otherwise we get

/home/samy/brl/translation/liblouis-git/tests/tables/bad.ctb:1: error: opcode 'bad' not defined.
1 errors found.
tests/tables/bad.ctb could not be compiled

=================================================================
==3022215==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 61 byte(s) in 1 object(s) allocated from:
    #0 0x7f67684e0545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75
    #1 0x7f676831b31a in __GI___strdup string/strdup.c:42
    #2 0x7f676849d47e in compileFile /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4650
    #3 0x7f676849d9b1 in compileTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4767
    #4 0x7f676849e011 in getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4939
    #5 0x7f676849dcb0 in _lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4848
    #6 0x7f676849dd0e in lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4860
    #7 0x7f676849e165 in lou_checkTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4978
    #8 0x55e477d791c2 in main /home/samy/brl/translation/liblouis-git/tests/checkTable.c:29
    #9 0x7f67682b47fc in __libc_start_main ../csu/libc-start.c:332
    #10 0x55e477d79099 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/checkTable+0x1099)

SUMMARY: LeakSanitizer: 61 byte(s) leaked in 1 allocation(s).
FAIL checkTable (exit status: 23)
bertfrees pushed a commit that referenced this pull request Mar 28, 2022
@sthibaul @bertfrees
SwapTest: Fix read overflow
a316640 
SwapTest has to check wheter it overflows the input. Otherwise we get in
tests/braille-specs/da-dk-g16-lit.log:

==43588==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000026712 at pc 0x7f7d9ff57381 bp 0x7fff050fd170 sp 0x7fff050fd168
READ of size 2 at 0x602000026712 thread T0
    #0 0x7f7d9ff57380 in swapTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:399
    #1 0x7f7d9ff5d22e in passDoTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:861
    #2 0x7f7d9ff552f2 in findForPassRule /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:211
    #3 0x7f7d9ff55ac9 in makeCorrections /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:276
    #4 0x7f7d9ff6128d in _lou_translate /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:1272
    #5 0x55b837c9bdac in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:180
    #6 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807
    #7 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869
    #8 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063
    #9 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332
    #10 0x55b837c914c9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tools/.libs/lou_checkyaml+0x64c9)

0x602000026712 is located 0 bytes to the right of 2-byte region [0x602000026710,0x602000026712)
allocated by thread T0 here:
    #0 0x7f7da00777cf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
    #1 0x55b837c9b8b6 in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:138
    #2 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807
    #3 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869
    #4 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063
    #5 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simait @egli