New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Korean Grade 2 table contributed by Joseph Lee #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This table includes support for reading English text using grade 2. This was requested by Korean user and is documented in NVDA ticket 3835 (http://community.nvda-project.org/ticket/3835) Korean users say that transcribers in Korea use grade 2 for English texts for Korean grade 2.
This was an oversight by the original author (see http://www.freelists.org/post/liblouis-liblouisxml/Fwd-RE-Korean-grade-2-table-with-English-grade-2-support). It was meant to be under the same license as the rest of the tables.
Let's ask Joseph for test data |
Hi, |
sthibaul
added a commit
to sthibaul/liblouis
that referenced
this pull request
Mar 25, 2022
Otherwise we get /home/samy/brl/translation/liblouis-git/tests/tables/bad.ctb:1: error: opcode 'bad' not defined. 1 errors found. tests/tables/bad.ctb could not be compiled ================================================================= ==3022215==ERROR: LeakSanitizer: detected memory leaks Direct leak of 61 byte(s) in 1 object(s) allocated from: #0 0x7f67684e0545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 liblouis#1 0x7f676831b31a in __GI___strdup string/strdup.c:42 liblouis#2 0x7f676849d47e in compileFile /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4650 liblouis#3 0x7f676849d9b1 in compileTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4767 liblouis#4 0x7f676849e011 in getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4939 liblouis#5 0x7f676849dcb0 in _lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4848 liblouis#6 0x7f676849dd0e in lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4860 liblouis#7 0x7f676849e165 in lou_checkTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4978 liblouis#8 0x55e477d791c2 in main /home/samy/brl/translation/liblouis-git/tests/checkTable.c:29 liblouis#9 0x7f67682b47fc in __libc_start_main ../csu/libc-start.c:332 liblouis#10 0x55e477d79099 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/checkTable+0x1099) SUMMARY: LeakSanitizer: 61 byte(s) leaked in 1 allocation(s). FAIL checkTable (exit status: 23)
sthibaul
added a commit
to sthibaul/liblouis
that referenced
this pull request
Mar 25, 2022
Since the "for" loop would always make "matches" NULL. Otherwise we get in tests/findTable.log: [...] 2 matches found ================================================================= ==3029162==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 liblouis#1 0x7f6433b636cc in list_conj /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:58 liblouis#2 0x7f6433b652c7 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 liblouis#3 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 liblouis#4 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 liblouis#5 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) Indirect leak of 32 byte(s) in 2 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 liblouis#1 0x7f6433b65293 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 liblouis#2 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 liblouis#3 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 liblouis#4 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 liblouis#1 0x7f6433b637f9 in list_conj /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:84 liblouis#2 0x7f6433b652c7 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 liblouis#3 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 liblouis#4 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 liblouis#5 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) SUMMARY: LeakSanitizer: 80 byte(s) leaked in 4 allocation(s). FAIL findTable (exit status: 23)
sthibaul
added a commit
to sthibaul/liblouis
that referenced
this pull request
Mar 25, 2022
Since the "for" loop would always make "matches" NULL. Otherwise we get in tests/findTable.log: [...] 2 matches found ================================================================= ==3029162==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 liblouis#1 0x7f6433b636cc in list_conj /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:58 liblouis#2 0x7f6433b652c7 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 liblouis#3 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 liblouis#4 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 liblouis#5 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) Indirect leak of 32 byte(s) in 2 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 liblouis#1 0x7f6433b65293 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 liblouis#2 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 liblouis#3 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 liblouis#4 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 liblouis#1 0x7f6433b637f9 in list_conj /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:84 liblouis#2 0x7f6433b652c7 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 liblouis#3 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 liblouis#4 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 liblouis#5 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) SUMMARY: LeakSanitizer: 80 byte(s) leaked in 4 allocation(s). FAIL findTable (exit status: 23)
sthibaul
added a commit
to sthibaul/liblouis
that referenced
this pull request
Mar 25, 2022
Since the "for" loop would always make "matches" NULL. Otherwise we get in tests/findTable.log: [...] 2 matches found ================================================================= ==3029162==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 liblouis#1 0x7f6433b636cc in list_conj /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:58 liblouis#2 0x7f6433b652c7 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 liblouis#3 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 liblouis#4 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 liblouis#5 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) Indirect leak of 32 byte(s) in 2 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 liblouis#1 0x7f6433b65293 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 liblouis#2 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 liblouis#3 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 liblouis#4 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 liblouis#1 0x7f6433b637f9 in list_conj /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:84 liblouis#2 0x7f6433b652c7 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 liblouis#3 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 liblouis#4 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 liblouis#5 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) SUMMARY: LeakSanitizer: 80 byte(s) leaked in 4 allocation(s). FAIL findTable (exit status: 23)
sthibaul
added a commit
to sthibaul/liblouis
that referenced
this pull request
Mar 25, 2022
Otherwise we get /home/samy/brl/translation/liblouis-git/tests/tables/bad.ctb:1: error: opcode 'bad' not defined. 1 errors found. tests/tables/bad.ctb could not be compiled ================================================================= ==3022215==ERROR: LeakSanitizer: detected memory leaks Direct leak of 61 byte(s) in 1 object(s) allocated from: #0 0x7f67684e0545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 liblouis#1 0x7f676831b31a in __GI___strdup string/strdup.c:42 liblouis#2 0x7f676849d47e in compileFile /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4650 liblouis#3 0x7f676849d9b1 in compileTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4767 liblouis#4 0x7f676849e011 in getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4939 liblouis#5 0x7f676849dcb0 in _lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4848 liblouis#6 0x7f676849dd0e in lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4860 liblouis#7 0x7f676849e165 in lou_checkTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4978 liblouis#8 0x55e477d791c2 in main /home/samy/brl/translation/liblouis-git/tests/checkTable.c:29 liblouis#9 0x7f67682b47fc in __libc_start_main ../csu/libc-start.c:332 liblouis#10 0x55e477d79099 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/checkTable+0x1099) SUMMARY: LeakSanitizer: 61 byte(s) leaked in 1 allocation(s). FAIL checkTable (exit status: 23)
sthibaul
added a commit
to sthibaul/liblouis
that referenced
this pull request
Mar 26, 2022
SwapTest has to check wheter it overflows the input. Otherwise we get in tests/braille-specs/da-dk-g16-lit.log: ==43588==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000026712 at pc 0x7f7d9ff57381 bp 0x7fff050fd170 sp 0x7fff050fd168 READ of size 2 at 0x602000026712 thread T0 #0 0x7f7d9ff57380 in swapTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:399 liblouis#1 0x7f7d9ff5d22e in passDoTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:861 liblouis#2 0x7f7d9ff552f2 in findForPassRule /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:211 liblouis#3 0x7f7d9ff55ac9 in makeCorrections /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:276 liblouis#4 0x7f7d9ff6128d in _lou_translate /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:1272 liblouis#5 0x55b837c9bdac in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:180 liblouis#6 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807 liblouis#7 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869 liblouis#8 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063 liblouis#9 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332 liblouis#10 0x55b837c914c9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tools/.libs/lou_checkyaml+0x64c9) 0x602000026712 is located 0 bytes to the right of 2-byte region [0x602000026710,0x602000026712) allocated by thread T0 here: #0 0x7f7da00777cf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145 liblouis#1 0x55b837c9b8b6 in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:138 liblouis#2 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807 liblouis#3 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869 liblouis#4 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063 liblouis#5 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332
sthibaul
added a commit
to sthibaul/liblouis
that referenced
this pull request
Mar 26, 2022
read_test gives parsed_strlen(word) to read_options, so that it gives it to read_typeforms, and thus typeform has that length. check_base should thus also use that length when memcpying it. Otherwise we get in braille-specs/de-g1.yaml: ==95136==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020000f451c at pc 0x7f5603f1b9b0 bp 0x7ffe24c6bc60 sp 0x7ffe24c6b410 READ of size 16 at 0x6020000f451c thread T0 #0 0x7f5603f1b9af in __interceptor_memcpy ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:827 liblouis#1 0x5626d22d983b in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:116 liblouis#2 0x5626d22d5717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807 liblouis#3 0x5626d22d5f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869 liblouis#4 0x5626d22d748a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063 liblouis#5 0x7f5603c5d7fc in __libc_start_main ../csu/libc-start.c:332 liblouis#6 0x5626d22cf4c9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tools/.libs/lou_checkyaml+0x64c9) 0x6020000f451c is located 0 bytes to the right of 12-byte region [0x6020000f4510,0x6020000f451c) allocated by thread T0 here: #0 0x7f5603f90987 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154 liblouis#1 0x5626d22d37b5 in read_typeforms /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:567 liblouis#2 0x5626d22d40c6 in read_options /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:642 liblouis#3 0x5626d22d51e7 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:774 liblouis#4 0x5626d22d5f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869 liblouis#5 0x5626d22d748a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063 liblouis#6 0x7f5603c5d7fc in __libc_start_main ../csu/libc-start.c:332
sthibaul
added a commit
to sthibaul/liblouis
that referenced
this pull request
Mar 26, 2022
read_test gives parsed_strlen(word) to read_options, so that it gives it to read_typeforms, and thus typeform has that length. check_base should thus also use that length when memcpying it. Otherwise we get in braille-specs/de-g1.yaml: ==95136==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020000f451c at pc 0x7f5603f1b9b0 bp 0x7ffe24c6bc60 sp 0x7ffe24c6b410 READ of size 16 at 0x6020000f451c thread T0 #0 0x7f5603f1b9af in __interceptor_memcpy ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:827 liblouis#1 0x5626d22d983b in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:116 liblouis#2 0x5626d22d5717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807 liblouis#3 0x5626d22d5f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869 liblouis#4 0x5626d22d748a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063 liblouis#5 0x7f5603c5d7fc in __libc_start_main ../csu/libc-start.c:332 liblouis#6 0x5626d22cf4c9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tools/.libs/lou_checkyaml+0x64c9) 0x6020000f451c is located 0 bytes to the right of 12-byte region [0x6020000f4510,0x6020000f451c) allocated by thread T0 here: #0 0x7f5603f90987 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154 liblouis#1 0x5626d22d37b5 in read_typeforms /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:567 liblouis#2 0x5626d22d40c6 in read_options /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:642 liblouis#3 0x5626d22d51e7 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:774 liblouis#4 0x5626d22d5f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869 liblouis#5 0x5626d22d748a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063 liblouis#6 0x7f5603c5d7fc in __libc_start_main ../csu/libc-start.c:332
bertfrees
pushed a commit
that referenced
this pull request
Mar 28, 2022
Otherwise we get /home/samy/brl/translation/liblouis-git/tests/tables/bad.ctb:1: error: opcode 'bad' not defined. 1 errors found. tests/tables/bad.ctb could not be compiled ================================================================= ==3022215==ERROR: LeakSanitizer: detected memory leaks Direct leak of 61 byte(s) in 1 object(s) allocated from: #0 0x7f67684e0545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 #1 0x7f676831b31a in __GI___strdup string/strdup.c:42 #2 0x7f676849d47e in compileFile /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4650 #3 0x7f676849d9b1 in compileTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4767 #4 0x7f676849e011 in getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4939 #5 0x7f676849dcb0 in _lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4848 #6 0x7f676849dd0e in lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4860 #7 0x7f676849e165 in lou_checkTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4978 #8 0x55e477d791c2 in main /home/samy/brl/translation/liblouis-git/tests/checkTable.c:29 #9 0x7f67682b47fc in __libc_start_main ../csu/libc-start.c:332 #10 0x55e477d79099 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/checkTable+0x1099) SUMMARY: LeakSanitizer: 61 byte(s) leaked in 1 allocation(s). FAIL checkTable (exit status: 23)
bertfrees
pushed a commit
that referenced
this pull request
Mar 28, 2022
Since the "for" loop would always make "matches" NULL. Otherwise we get in tests/findTable.log: [...] 2 matches found ================================================================= ==3029162==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 #1 0x7f6433b636cc in list_conj /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:58 #2 0x7f6433b652c7 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 #3 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 #4 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 #5 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) Indirect leak of 32 byte(s) in 2 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 #1 0x7f6433b65293 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 #2 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 #3 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 #4 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7f6433b92545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75 #1 0x7f6433b637f9 in list_conj /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:84 #2 0x7f6433b652c7 in lou_findTables /home/samy/brl/translation/liblouis-git/liblouis/metadata.c:767 #3 0x55c2bddf4291 in main /home/samy/brl/translation/liblouis-git/tests/findTable.c:33 #4 0x7f64339667fc in __libc_start_main ../csu/libc-start.c:332 #5 0x55c2bddf40d9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/findTable+0x10d9) SUMMARY: LeakSanitizer: 80 byte(s) leaked in 4 allocation(s). FAIL findTable (exit status: 23)
bertfrees
pushed a commit
that referenced
this pull request
Mar 28, 2022
SwapTest has to check wheter it overflows the input. Otherwise we get in tests/braille-specs/da-dk-g16-lit.log: ==43588==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000026712 at pc 0x7f7d9ff57381 bp 0x7fff050fd170 sp 0x7fff050fd168 READ of size 2 at 0x602000026712 thread T0 #0 0x7f7d9ff57380 in swapTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:399 #1 0x7f7d9ff5d22e in passDoTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:861 #2 0x7f7d9ff552f2 in findForPassRule /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:211 #3 0x7f7d9ff55ac9 in makeCorrections /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:276 #4 0x7f7d9ff6128d in _lou_translate /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:1272 #5 0x55b837c9bdac in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:180 #6 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807 #7 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869 #8 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063 #9 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332 #10 0x55b837c914c9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tools/.libs/lou_checkyaml+0x64c9) 0x602000026712 is located 0 bytes to the right of 2-byte region [0x602000026710,0x602000026712) allocated by thread T0 here: #0 0x7f7da00777cf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145 #1 0x55b837c9b8b6 in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:138 #2 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807 #3 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869 #4 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063 #5 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332
bertfrees
pushed a commit
that referenced
this pull request
Mar 28, 2022
read_test gives parsed_strlen(word) to read_options, so that it gives it to read_typeforms, and thus typeform has that length. check_base should thus also use that length when memcpying it. Otherwise we get in braille-specs/de-g1.yaml: ==95136==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020000f451c at pc 0x7f5603f1b9b0 bp 0x7ffe24c6bc60 sp 0x7ffe24c6b410 READ of size 16 at 0x6020000f451c thread T0 #0 0x7f5603f1b9af in __interceptor_memcpy ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:827 #1 0x5626d22d983b in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:116 #2 0x5626d22d5717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807 #3 0x5626d22d5f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869 #4 0x5626d22d748a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063 #5 0x7f5603c5d7fc in __libc_start_main ../csu/libc-start.c:332 #6 0x5626d22cf4c9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tools/.libs/lou_checkyaml+0x64c9) 0x6020000f451c is located 0 bytes to the right of 12-byte region [0x6020000f4510,0x6020000f451c) allocated by thread T0 here: #0 0x7f5603f90987 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154 #1 0x5626d22d37b5 in read_typeforms /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:567 #2 0x5626d22d40c6 in read_options /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:642 #3 0x5626d22d51e7 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:774 #4 0x5626d22d5f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869 #5 0x5626d22d748a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063 #6 0x7f5603c5d7fc in __libc_start_main ../csu/libc-start.c:332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This table includes support for reading English text using grade 2. This was requested by Korean user and is documented in NVDA ticket 3835 (http://community.nvda-project.org/ticket/3835)
Korean users say that transcribers in Korea use grade 2 for English texts for Korean grade 2.