Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tables for Cherokee, Afrikaans, Maori and Hawaiian from Greg Kearney #9

Merged
merged 12 commits into from Aug 27, 2014
Merged

Tables for Cherokee, Afrikaans, Maori and Hawaiian from Greg Kearney #9

merged 12 commits into from Aug 27, 2014

Conversation

bertfrees
Copy link
Member

Afrikaans, Cherokee, Maori and Hawiian all are grade 1 tables and with the exception of Cherokee were derived from World Braille Usage 2013. The Cherokee was taken from the specification published at www.cbtbc.org/cherokee/

@egli
Copy link
Member

egli commented Jun 26, 2014

Can we have the same names as the other tables? We need to have one naming scheme. Either we switch all tables to the proposed naming scheme or none. We do not want some tables with one naming scheme and some with another.

@bertfrees
Copy link
Member Author

I don't really understand. What's the problem with the names? We don't have a standard naming scheme now do we? Besides I wouldn't give too much importance to the file names. The standard metadata in table headers is what's really important IMO.

@egli
Copy link
Member

egli commented Jun 27, 2014

Well we sorta do have a naming scheme. Look at de-ch-g2.ctb. Greg proposes to add some stuff to it and hence his tables are called afr-za-g1.ctb. I think we should at least try to have only one naming scheme and not several. So if we could name the tables according to the current naming scheme then I would be much happier. AFAIK @mhameed once did a big renaming fest to get us to where we are now.

@bertfrees
Copy link
Member Author

OK but we already have several. I thought the problem was that it's not even possible to come up with a simple uniform scheme that can capture all special cases, that's why we're going for the metadata in headers idea. So should we go through the effort? OK in this case it's a simple change and it actually makes sense, but in other cases maybe it won't?

@egli
Copy link
Member

egli commented Jun 27, 2014

Are we going for the meta data idea? I think until we are going for some idea and change all tables we should stick to the current naming scheme.

@bertfrees
Copy link
Member Author

For Cherokee and Hawaiian there aren't even 2-letter codes. (see http://www.loc.gov/standards/iso639-2/php/code_list.php)

@bertfrees bertfrees force-pushed the tables/cherokee_afrikaans_maori_hawaiian branch from 24b7604 to 93cd8d1 Compare August 20, 2014 19:34
@egli
Copy link
Member

egli commented Aug 26, 2014

We need a NEWS entry

@egli
Copy link
Member

egli commented Aug 27, 2014

OK, the NEWS entry is there now. There is a mix of licenses. Most of them are GPL and some are LGPL. Can we have them all as LGPL?

@egli
Change the license to LGPLv2.1+
4b50234 
Greg gave me permission to distribute the files under public domain (see
http://www.freelists.org/post/liblouis-liblouisxml/Fwd-Re-License-of-Afrikaans-Cherokee-Hawaiian-Maori-Sotho-and-Tswana-tables).
To align the license with the rest of the tables I am changing the
license of his tables to LGPL version 2.1
@egli
Copy link
Member

egli commented Aug 27, 2014

We have permission from Greg to change the license. They are changed now, so we should be ready for a merge.

egli added a commit that referenced this pull request Aug 27, 2014
@egli
Merge pull request #9 from liblouis/tables/cherokee_afrikaans_maori_h…
b0d1750 
…awaiian

Tables for Cherokee, Afrikaans, Maori and Hawaiian from Greg Kearney
@egli egli merged commit b0d1750 into master Aug 27, 2014
@egli egli deleted the tables/cherokee_afrikaans_maori_hawaiian branch September 1, 2014 08:41
sthibaul added a commit to sthibaul/liblouis that referenced this pull request Mar 25, 2022
@sthibaul
Fix memory leak on table compilation error
456e7b5 
Otherwise we get

/home/samy/brl/translation/liblouis-git/tests/tables/bad.ctb:1: error: opcode 'bad' not defined.
1 errors found.
tests/tables/bad.ctb could not be compiled

=================================================================
==3022215==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 61 byte(s) in 1 object(s) allocated from:
    #0 0x7f67684e0545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75
    liblouis#1 0x7f676831b31a in __GI___strdup string/strdup.c:42
    liblouis#2 0x7f676849d47e in compileFile /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4650
    liblouis#3 0x7f676849d9b1 in compileTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4767
    liblouis#4 0x7f676849e011 in getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4939
    liblouis#5 0x7f676849dcb0 in _lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4848
    liblouis#6 0x7f676849dd0e in lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4860
    liblouis#7 0x7f676849e165 in lou_checkTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4978
    liblouis#8 0x55e477d791c2 in main /home/samy/brl/translation/liblouis-git/tests/checkTable.c:29
    liblouis#9 0x7f67682b47fc in __libc_start_main ../csu/libc-start.c:332
    liblouis#10 0x55e477d79099 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/checkTable+0x1099)

SUMMARY: LeakSanitizer: 61 byte(s) leaked in 1 allocation(s).
FAIL checkTable (exit status: 23)
@sthibaul sthibaul mentioned this pull request Mar 25, 2022
Closed
sthibaul added a commit to sthibaul/liblouis that referenced this pull request Mar 25, 2022
@sthibaul
Fix memory leak on table compilation error
b166bdc 
Otherwise we get

/home/samy/brl/translation/liblouis-git/tests/tables/bad.ctb:1: error: opcode 'bad' not defined.
1 errors found.
tests/tables/bad.ctb could not be compiled

=================================================================
==3022215==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 61 byte(s) in 1 object(s) allocated from:
    #0 0x7f67684e0545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75
    liblouis#1 0x7f676831b31a in __GI___strdup string/strdup.c:42
    liblouis#2 0x7f676849d47e in compileFile /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4650
    liblouis#3 0x7f676849d9b1 in compileTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4767
    liblouis#4 0x7f676849e011 in getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4939
    liblouis#5 0x7f676849dcb0 in _lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4848
    liblouis#6 0x7f676849dd0e in lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4860
    liblouis#7 0x7f676849e165 in lou_checkTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4978
    liblouis#8 0x55e477d791c2 in main /home/samy/brl/translation/liblouis-git/tests/checkTable.c:29
    liblouis#9 0x7f67682b47fc in __libc_start_main ../csu/libc-start.c:332
    liblouis#10 0x55e477d79099 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/checkTable+0x1099)

SUMMARY: LeakSanitizer: 61 byte(s) leaked in 1 allocation(s).
FAIL checkTable (exit status: 23)
sthibaul added a commit to sthibaul/liblouis that referenced this pull request Mar 26, 2022
@sthibaul
SwapTest: Fix read overflow
2ed8aac 
SwapTest has to check wheter it overflows the input. Otherwise we get in
tests/braille-specs/da-dk-g16-lit.log:

==43588==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000026712 at pc 0x7f7d9ff57381 bp 0x7fff050fd170 sp 0x7fff050fd168
READ of size 2 at 0x602000026712 thread T0
    #0 0x7f7d9ff57380 in swapTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:399
    liblouis#1 0x7f7d9ff5d22e in passDoTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:861
    liblouis#2 0x7f7d9ff552f2 in findForPassRule /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:211
    liblouis#3 0x7f7d9ff55ac9 in makeCorrections /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:276
    liblouis#4 0x7f7d9ff6128d in _lou_translate /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:1272
    liblouis#5 0x55b837c9bdac in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:180
    liblouis#6 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807
    liblouis#7 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869
    liblouis#8 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063
    liblouis#9 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332
    liblouis#10 0x55b837c914c9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tools/.libs/lou_checkyaml+0x64c9)

0x602000026712 is located 0 bytes to the right of 2-byte region [0x602000026710,0x602000026712)
allocated by thread T0 here:
    #0 0x7f7da00777cf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
    liblouis#1 0x55b837c9b8b6 in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:138
    liblouis#2 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807
    liblouis#3 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869
    liblouis#4 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063
    liblouis#5 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332
@sthibaul sthibaul mentioned this pull request Mar 26, 2022
Closed
bertfrees pushed a commit that referenced this pull request Mar 28, 2022
@sthibaul @bertfrees
Fix memory leak on table compilation error
22b2ae1 
Otherwise we get

/home/samy/brl/translation/liblouis-git/tests/tables/bad.ctb:1: error: opcode 'bad' not defined.
1 errors found.
tests/tables/bad.ctb could not be compiled

=================================================================
==3022215==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 61 byte(s) in 1 object(s) allocated from:
    #0 0x7f67684e0545 in __interceptor_malloc ../../../../src/libsanitizer/lsan/lsan_interceptors.cpp:75
    #1 0x7f676831b31a in __GI___strdup string/strdup.c:42
    #2 0x7f676849d47e in compileFile /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4650
    #3 0x7f676849d9b1 in compileTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4767
    #4 0x7f676849e011 in getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4939
    #5 0x7f676849dcb0 in _lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4848
    #6 0x7f676849dd0e in lou_getTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4860
    #7 0x7f676849e165 in lou_checkTable /home/samy/brl/translation/liblouis-git/liblouis/compileTranslationTable.c:4978
    #8 0x55e477d791c2 in main /home/samy/brl/translation/liblouis-git/tests/checkTable.c:29
    #9 0x7f67682b47fc in __libc_start_main ../csu/libc-start.c:332
    #10 0x55e477d79099 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tests/.libs/checkTable+0x1099)

SUMMARY: LeakSanitizer: 61 byte(s) leaked in 1 allocation(s).
FAIL checkTable (exit status: 23)
bertfrees pushed a commit that referenced this pull request Mar 28, 2022
@sthibaul @bertfrees
SwapTest: Fix read overflow
a316640 
SwapTest has to check wheter it overflows the input. Otherwise we get in
tests/braille-specs/da-dk-g16-lit.log:

==43588==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000026712 at pc 0x7f7d9ff57381 bp 0x7fff050fd170 sp 0x7fff050fd168
READ of size 2 at 0x602000026712 thread T0
    #0 0x7f7d9ff57380 in swapTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:399
    #1 0x7f7d9ff5d22e in passDoTest /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:861
    #2 0x7f7d9ff552f2 in findForPassRule /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:211
    #3 0x7f7d9ff55ac9 in makeCorrections /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:276
    #4 0x7f7d9ff6128d in _lou_translate /home/samy/brl/translation/liblouis-git/liblouis/lou_translateString.c:1272
    #5 0x55b837c9bdac in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:180
    #6 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807
    #7 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869
    #8 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063
    #9 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332
    #10 0x55b837c914c9 in _start (/home/samy/ens/projet/1/translation/liblouis-git/tools/.libs/lou_checkyaml+0x64c9)

0x602000026712 is located 0 bytes to the right of 2-byte region [0x602000026710,0x602000026712)
allocated by thread T0 here:
    #0 0x7f7da00777cf in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
    #1 0x55b837c9b8b6 in check_base /home/samy/brl/translation/liblouis-git/tools/brl_checks.c:138
    #2 0x55b837c97717 in read_test /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:807
    #3 0x55b837c97f69 in read_tests /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:869
    #4 0x55b837c9948a in main /home/samy/brl/translation/liblouis-git/tools/lou_checkyaml.c:1063
    #5 0x7f7d9fd447fc in __libc_start_main ../csu/libc-start.c:332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bertfrees @egli