Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranged should be deprecated (again) #44

Open
9il opened this issue Sep 17, 2016 · 5 comments
Open

ranged should be deprecated (again) #44

9il opened this issue Sep 17, 2016 · 5 comments

Comments

@9il
Copy link
Member

9il commented Sep 17, 2016

As soon as mir.image be implemented, we will have good conversions between all formats we use. ranged is functions that stretch color domain for each channel. If you apply this for not very contrast image, it will make it more contrast. This implicit filter functionality is bad practice.

@ljubobratovicrelja
Copy link
Member

If you apply this for not very contrast image, it will make it more contrast

Well, use should use histogram equalization to do that. ranged is not the right tool for contrast enhancement. There will be some more advanced methods for histogram equalization in DCV, but that's the basics.

This implicit filter functionality is bad practice

Primary use of ranged is not to adjust contrast in images. It is a simple tool, used often in signal (image) processing, in various occasions to linearly stretch the histogram. This is analogue to OpenCV's cv::normalize with norm type of NORM_MINMAX. Sorry, but ranged will not be deprecated, except mir.image can offer exactly the same functionality with as simple API.

@9il
Copy link
Member Author

9il commented Sep 17, 2016

OK, but I am worrying that it is frequently used in DCV. BTW, I will add minmax and scale to Mir. So ranged will be optimized with this two functions.

@9il 9il closed this as completed Sep 17, 2016
@ljubobratovicrelja
Copy link
Member

BTW, I will add minmax to Mir and scale

This is a whole another story. If those functions are present in low-level API manor, I'm sold. We'll deprecate ranged.

Reopening, and idling until minmax and scale are present in mir. Good?

@9il
Copy link
Member Author

9il commented Sep 17, 2016

Yep, thanks!

@ljubobratovicrelja
Copy link
Member

Np, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants