Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mir.algorithm - Sorting, searching and counting #50

Closed
wilzbach opened this issue Apr 10, 2016 · 12 comments
Closed

mir.algorithm - Sorting, searching and counting #50

wilzbach opened this issue Apr 10, 2016 · 12 comments

Comments

@wilzbach
Copy link
Member

Ideally this would seamlessly integrate with the existing algorithms in Phobos from std.algorithm.

I don't know what we do with new algorithms, but mir.algorithm sounds like a good place?
At least sorting, partitioning, counting and searching should be checked.

See also:
https://github.com/DlangScience/mir/wiki/NumPy:-Sorting,-searching,-and-counting

@9il
Copy link
Member

9il commented Apr 10, 2016

Probably this name would never be used. What you can place here?

@9il
Copy link
Member

9il commented Apr 10, 2016

Sorting, searching and counting can be done with std.algorithm. Any use case, which should be put here?

@wilzbach
Copy link
Member Author

AFAIK phobos doesn't have any windowing function.

@9il
Copy link
Member

9il commented Apr 10, 2016

but ndslice already has windows

@wilzbach
Copy link
Member Author

This issue is also about creating some documentation and tests that ensure that std.algorithm works fine with Ndslice - especially the documentation is important to users.

@wilzbach
Copy link
Member Author

but ndslice already has windows

Okay then this is only to write a guideguide or tutorial.

@9il
Copy link
Member

9il commented Apr 10, 2016

This issue is also about creating some documentation and tests that ensure that std.algorithm works fine with Ndslice - especially the documentation is important to users.

The best option is mir.ndslice.example with a lot of unittests, which contains a 1-3 lines functions to cover numpy.

@9il
Copy link
Member

9il commented Apr 10, 2016

BTW, half of check boxes in our wiki about numpy should be turn on. They are 1-3 lines functions.

@9il
Copy link
Member

9il commented Apr 10, 2016

BTW, half of check boxes in our wiki about numpy should be turn on. They are 1-3 lines functions.

However this is useless without examples

@wilzbach
Copy link
Member Author

Closing in favor of #77 and #78

@wilzbach
Copy link
Member Author

I found a good example in ndslice - median (from the examples in package.d) could be part of such a package.

@wilzbach wilzbach reopened this Apr 18, 2016
@9il
Copy link
Member

9il commented Apr 18, 2016

I found a good example in ndslice - median (from the examples in package.d) could be part of such a package.

This would in filters or something specialized. algorithm assumes something general purposed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants