Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOGD changing sign of Cosine instead of Sine #3

Open
BillyBarbaro opened this issue Dec 6, 2017 · 0 comments
Open

FOGD changing sign of Cosine instead of Sine #3

BillyBarbaro opened this issue Dec 6, 2017 · 0 comments

Comments

@BillyBarbaro
Copy link

FOGD includes an implementation of sine and cosine calculations using a method that's described in this blog post. The way it's implemented in FOGD, it seems like p1 is meant to represent the cosine and p2 the sine; however, looking at the formulas from the post (and computing the values on my own), this appears to be flipped, i.e. p1 is sine and p2 is cosine. This leads to a problem here where the sign of p2 is flipped if the angle of negative. This would be correct if p2 was sine, but is not correct since p2 is actually the cosine of the angle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant