-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWX-32294 : Reconfigure SCC templates #1132
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
=======================================
Coverage 75.55% 75.55%
=======================================
Files 64 64
Lines 17853 17853
=======================================
Hits 13488 13488
Misses 3408 3408
Partials 957 957
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check if the PX actually deploys with these settings?
- if you didn't, please do check before the commit
Note, there is one change that you missed (line 239, should also set AllowPrivilegeEscalation: false
for the "restricted" conf
- please fix this before the commit
Other than this, the DIFF looks OK -- thanks Nikita!
Yes, with these changes, deployed px version 3.0.0 and all pods were up and running. NAME READY STATUS RESTARTS AGE |
Reconfigure both SCC templates to remove the following privileges:
Powrtworx-restricted scc already have these privileges, changed portworx SCC to have these priveileges