Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add portworx-restricted scc #988

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Conversation

siyingjin
Copy link
Contributor

@siyingjin siyingjin commented Mar 22, 2023

What this PR does / why we need it:
Add a scc portworx-restricted, and use it for stork, csi, pvc controller, lighthouse.

Which issue(s) this PR fixes (optional)
Ticket: https://portworx.atlassian.net/browse/PWX-27673

Test:
Upgrade operator with my test image, and delete one pod of each kind, and verify the pod is back to running state. Confirmed "Updating security context constraints" only show 1 time.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (8853b15) 77.76% compared to head (3f78dad) 77.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
+ Coverage   77.76%   77.82%   +0.05%     
==========================================
  Files          59       59              
  Lines       16242    16285      +43     
==========================================
+ Hits        12631    12674      +43     
  Misses       2747     2747              
  Partials      864      864              
Impacted Files Coverage Δ
drivers/storage/portworx/component/csi.go 92.24% <100.00%> (ø)
drivers/storage/portworx/component/lighthouse.go 93.43% <100.00%> (ø)
...rivers/storage/portworx/component/pvccontroller.go 94.20% <100.00%> (ø)
...e/portworx/component/securitycontextconstraints.go 86.55% <100.00%> (+4.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@pure-jliao pure-jliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to validate this on a OCP cluster before merge.

@siyingjin siyingjin merged commit f7d2401 into libopenstorage:master Mar 23, 2023
siyingjin added a commit to siyingjin/operator that referenced this pull request Mar 30, 2023
)

* Add portworx-restricted scc

* Add portworx restricted scc to cluster role
nikita-bhatia pushed a commit that referenced this pull request Jul 14, 2023
* Add portworx-restricted scc

* Add portworx restricted scc to cluster role
nikita-bhatia added a commit that referenced this pull request Jul 14, 2023
…1140)

* Add portworx-restricted scc (#988)

* Add portworx-restricted scc

* Add portworx restricted scc to cluster role

* cherry PWX-32294

* remove RequiredDropCapabilities from testspec

* fix failing TestSCC test

---------

Co-authored-by: siyingjin <122411280+siyingjin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants