Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick PWX-31562 : Operator's Windows support #1211

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

nikita-bhatia
Copy link
Contributor

Cherrypick #1176 to 23.7.1 branch

* Add windows operator support

* update daemonset labels

* Replace nodeselecter with nodeaffinity

* Add tests

* add nodeselector for stork and stork-scheduler

* remove nodeaffinity from components

* add nodeselector as linux in storagecluster

* address review comments

* address review comments

* address review comments

* update windows specific affinity and tolerations

* add px-installer daemonset for windows

* fix failing tests

* fix failing tests

* remove fmt logs

* set default csi-installer image for windows

* fix failing test

* fix review comments

* fix failing test

* rename px driver and node-win daemonset file names

* remove fmt logs

* rename px-csi-node-win-shared daemonset to px-csi-node-win
@nikita-bhatia nikita-bhatia changed the title Cherrypick PWX-31562 : Operator's Windows support (#1176) Cherrypick PWX-31562 : Operator's Windows support Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 83.53% and project coverage change: +0.03% 🎉

Comparison is base (feab48c) 80.05% compared to head (c540a30) 80.09%.

Additional details and impacted files
@@                Coverage Diff                @@
##           px-rel-23.7.1    #1211      +/-   ##
=================================================
+ Coverage          80.05%   80.09%   +0.03%     
=================================================
  Files                 58       59       +1     
  Lines              16577    16741     +164     
=================================================
+ Hits               13271    13408     +137     
- Misses              2375     2390      +15     
- Partials             931      943      +12     
Files Changed Coverage Δ
drivers/storage/portworx/component/windows.go 80.85% <80.85%> (ø)
drivers/storage/portworx/deployment.go 95.80% <100.00%> (+0.01%) ⬆️
drivers/storage/portworx/manifest/manifest.go 91.03% <100.00%> (+0.12%) ⬆️
drivers/storage/portworx/portworx.go 85.74% <100.00%> (+0.03%) ⬆️
drivers/storage/portworx/util/csi_generator.go 100.00% <100.00%> (ø)
drivers/storage/portworx/util/util.go 84.91% <100.00%> (+0.24%) ⬆️
pkg/migration/generate.go 88.83% <100.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikita-bhatia nikita-bhatia merged commit 9fe2e10 into px-rel-23.7.1 Aug 16, 2023
8 checks passed
@nikita-bhatia nikita-bhatia deleted the cherrypick-windows-support branch August 17, 2023 06:01
nikita-bhatia added a commit that referenced this pull request Aug 22, 2023
* Add windows operator support

* update daemonset labels

* Replace nodeselecter with nodeaffinity

* Add tests

* add nodeselector for stork and stork-scheduler

* remove nodeaffinity from components

* add nodeselector as linux in storagecluster

* address review comments

* address review comments

* address review comments

* update windows specific affinity and tolerations

* add px-installer daemonset for windows

* fix failing tests

* fix failing tests

* remove fmt logs

* set default csi-installer image for windows

* fix failing test

* fix review comments

* fix failing test

* rename px driver and node-win daemonset file names

* remove fmt logs

* rename px-csi-node-win-shared daemonset to px-csi-node-win
nikita-bhatia added a commit that referenced this pull request Aug 24, 2023
* PWX-31562 : Operator's Windows support (#1211)

* Add windows operator support

* update daemonset labels

* Replace nodeselecter with nodeaffinity

* Add tests

* add nodeselector for stork and stork-scheduler

* remove nodeaffinity from components

* add nodeselector as linux in storagecluster

* address review comments

* address review comments

* address review comments

* update windows specific affinity and tolerations

* add px-installer daemonset for windows

* fix failing tests

* fix failing tests

* remove fmt logs

* set default csi-installer image for windows

* fix failing test

* fix review comments

* fix failing test

* rename px driver and node-win daemonset file names

* remove fmt logs

* rename px-csi-node-win-shared daemonset to px-csi-node-win

* PWX-33085, PWX-33086 : Add linux nodeaffinity for operator  (#1216)

* Add linux nodeaffinity for operator

* enable windows component only if k8s version is greater or equal to 1.25

* update linux as os in nodeaffinity

* update linux as os in nodeaffinity

* PWX-33087 : CsiWindowsDriver image is not populating is storagecluster desired images (#1219)

* Update yaml tag for csiWindowsDriver to match with spec generator

* update csiWindowsDriver tag in storagecluster crd

* correct nodeaffinity format

* rename toleration from windows to Windows

* build fix

* Add nodeaffinity to operator 23.7.0

---------

Co-authored-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants