PWX-33087 : CsiWindowsDriver image is not populating is storagecluster desired images #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-bhatia
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## px-rel-23.7.1 #1219 +/- ##
==============================================
Coverage 80.09% 80.09%
==============================================
Files 59 59
Lines 16741 16742 +1
==============================================
+ Hits 13408 13409 +1
Misses 2390 2390
Partials 943 943
☔ View full report in Codecov by Sentry. |
piyush-nimbalkar
approved these changes
Aug 21, 2023
nikita-bhatia
added a commit
that referenced
this pull request
Aug 22, 2023
…r desired images (#1219) * Update yaml tag for csiWindowsDriver to match with spec generator * update csiWindowsDriver tag in storagecluster crd * correct nodeaffinity format * rename toleration from windows to Windows * build fix
nikita-bhatia
added a commit
that referenced
this pull request
Aug 24, 2023
* PWX-31562 : Operator's Windows support (#1211) * Add windows operator support * update daemonset labels * Replace nodeselecter with nodeaffinity * Add tests * add nodeselector for stork and stork-scheduler * remove nodeaffinity from components * add nodeselector as linux in storagecluster * address review comments * address review comments * address review comments * update windows specific affinity and tolerations * add px-installer daemonset for windows * fix failing tests * fix failing tests * remove fmt logs * set default csi-installer image for windows * fix failing test * fix review comments * fix failing test * rename px driver and node-win daemonset file names * remove fmt logs * rename px-csi-node-win-shared daemonset to px-csi-node-win * PWX-33085, PWX-33086 : Add linux nodeaffinity for operator (#1216) * Add linux nodeaffinity for operator * enable windows component only if k8s version is greater or equal to 1.25 * update linux as os in nodeaffinity * update linux as os in nodeaffinity * PWX-33087 : CsiWindowsDriver image is not populating is storagecluster desired images (#1219) * Update yaml tag for csiWindowsDriver to match with spec generator * update csiWindowsDriver tag in storagecluster crd * correct nodeaffinity format * rename toleration from windows to Windows * build fix * Add nodeaffinity to operator 23.7.0 --------- Co-authored-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes : https://portworx.atlassian.net/browse/PWX-33087
Bug fix :
Test :
Verified on k8s 1.25.8 cluster
Following is the status of STC :
status:
clusterName: px-clusters
desiredImages:
autopilot: portworx/autopilot:1.3.8
csiAttacher: docker.io/openstorage/csi-attacher:v1.2.1-1
csiLivenessProbe: registry.k8s.io/sig-storage/livenessprobe:v2.10.0
csiNodeDriverRegistrar: registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0
csiProvisioner: registry.k8s.io/sig-storage/csi-provisioner:v3.5.0
csiResizer: registry.k8s.io/sig-storage/csi-resizer:v1.8.0
csiSnapshotController: registry.k8s.io/sig-storage/snapshot-controller:v6.2.2
csiSnapshotter: registry.k8s.io/sig-storage/csi-snapshotter:v6.2.2
csiWindowsDriver: docker.io/portworx/px-windows-csi-driver:v0.1
dynamicPlugin: portworx/portworx-dynamic-plugin:1.1.0
dynamicPluginProxy: nginxinc/nginx-unprivileged:1.23
prometheus: quay.io/prometheus/prometheus:v2.35.0
prometheusConfigReloader: quay.io/prometheus-operator/prometheus-config-reloader:v0.56.3
prometheusOperator: quay.io/prometheus-operator/prometheus-operator:v0.56.3
stork: openstorage/stork:23.7.0
phase: Initializing
storage: {}
version: f5a2c6e_d46fecd