Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-33069: Upgrading golang to 1.20.7 #1215

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Conversation

zoxpx
Copy link
Collaborator

@zoxpx zoxpx commented Aug 17, 2023

  • also updating linter-tools

What this PR does / why we need it:

We're changing golang-compiler version 1.19.1 -> 1.20.7

Note, there was a drastic reduction of vendor/ -files

  • this is due to removal of github.com/golangci/golangci-lint@v1.50.1 code-dependency
  • the golangci-lint@v1.50.1 is buggy (hangs + memory-leak w/ go-1.20), and also
  • we switched to using a golangci-lint binary - so we don't need to "keep the sources of the tool"

Which issue(s) this PR fixes (optional)
Closes # PWX-33069

Special notes for your reviewer:

@zoxpx zoxpx self-assigned this Aug 17, 2023
@zoxpx zoxpx force-pushed the upgrading_golang_and_tools branch from 4357bcf to e618b6c Compare August 17, 2023 01:15
@zoxpx zoxpx changed the title Upgrading golang to 1.20.7 PWX-33069: Upgrading golang to 1.20.7 Aug 17, 2023
* also updating linter-tools

Signed-off-by: Zoran Rajic <zox@portworx.com>
@zoxpx
Copy link
Collaborator Author

zoxpx commented Aug 17, 2023

Note -- Travis failed due to unrelated:

[2023-08-17T16:16:09.569Z]         	            	+     Annotations: (map[string]string) (len=2) {
[2023-08-17T16:16:09.569Z]         	            	+      (string) (len=11) "description": (string) (len=103) "Failed to set up Portworx license on {{$labels.instance}}. Please check licenses and/or license server.",
[2023-08-17T16:16:09.569Z]         	            	+      (string) (len=7) "summary": (string) (len=58) "Failed to set up Portworx license on {{$labels.instance}}."
[2023-08-17T16:16:09.569Z]         	            	+     }
[2023-08-17T16:16:09.569Z]         	            	+    }
[2023-08-17T16:16:09.569Z]         	            	+   },
[2023-08-17T16:16:09.569Z]         	            	+   PartialResponseStrategy: (string) ""
[2023-08-17T16:16:09.569Z]         	            	   }
[2023-08-17T16:16:09.569Z]         	Test:       	TestMonitoringMetricsEnabled
[2023-08-17T16:16:09.569Z] --- FAIL: TestMonitoringMetricsEnabled (0.01s)
  • the pxdocs got updated w/ the new prometheous-rules, and the build did not pick it up..

@zoxpx zoxpx force-pushed the upgrading_golang_and_tools branch from 041aa36 to cc9e81f Compare August 17, 2023 18:36
@zoxpx
Copy link
Collaborator Author

zoxpx commented Aug 21, 2023

Ping -- any chance of getting a review on this PR ?

Note, the PR "looks scary" (1800 vendor/ -files removed) -- but this is because we had golangci-lint sources checked in (used w/ make lint). Since there is no need to keep the linter-tool sources checked in, I removed them, and caused 1800-files diff.

@zoxpx zoxpx requested a review from a team August 21, 2023 20:51
Copy link
Contributor

@nikita-bhatia nikita-bhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please run operater regression job to make sure nothing is breaking before merging the PR :)

@zoxpx
Copy link
Collaborator Author

zoxpx commented Aug 23, 2023

Looks like most Operator tests are taking edge-install.portworx.com as an "input parameter", so

  • I've tested this PR manually, and
  • will retest once the code is committed in master-branch, and before cherry-picking to px-rel-23.7.0

@zoxpx zoxpx merged commit 110312d into master Aug 23, 2023
9 checks passed
@zoxpx zoxpx deleted the upgrading_golang_and_tools branch August 23, 2023 01:27
@zoxpx
Copy link
Collaborator Author

zoxpx commented Aug 24, 2023

@zoxpx
Copy link
Collaborator Author

zoxpx commented Aug 24, 2023

Proceeding to cherry-pick to px-rel-23.7.0

zoxpx added a commit that referenced this pull request Aug 24, 2023
* also updating linter-tools and integration-tests

Signed-off-by: Zoran Rajic <zox@portworx.com>

Manually fixed Conflicts:
	Makefile
	go.mod
	go.sum
	vendor/github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1/prometheus_types.go
	vendor/modules.txt
zoxpx added a commit that referenced this pull request Aug 24, 2023
* linter-tools cleanup (#829)
  - fixing makefile rules for linter-tools  (golangci-lint, errcheck, staticcheck)
  - removed unused gomock tool

* PWX-33069: Upgrading golang to 1.20.7 (#1215)
  - also updating linter-tools and integration-tests

* add missing /vendor dirs

Manually fixed Conflicts:
	Makefile
	go.mod
	go.sum
	vendor/github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1/prometheus_types.go
	vendor/modules.txt

Signed-off-by: Zoran Rajic <zox@portworx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants