-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWX-33069: Upgrading golang to 1.20.7 #1215
Conversation
4357bcf
to
e618b6c
Compare
* also updating linter-tools Signed-off-by: Zoran Rajic <zox@portworx.com>
Note -- Travis failed due to unrelated:
|
041aa36
to
cc9e81f
Compare
Ping -- any chance of getting a review on this PR ? Note, the PR "looks scary" (1800 vendor/ -files removed) -- but this is because we had |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please run operater regression job to make sure nothing is breaking before merging the PR :)
Looks like most Operator tests are taking edge-install.portworx.com as an "input parameter", so
|
Security scan report @ https://aetos.pwx.purestorage.com/security/Operator/master/2023-08-24-00-45-59-261286
Jenkins test @ https://jenkins.pwx.dev.purestorage.com/job/Operator/view/Operator%20Release%20Dashboard/job/op-basic-hotfix/32/
|
Proceeding to cherry-pick to |
* also updating linter-tools and integration-tests Signed-off-by: Zoran Rajic <zox@portworx.com> Manually fixed Conflicts: Makefile go.mod go.sum vendor/github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1/prometheus_types.go vendor/modules.txt
* linter-tools cleanup (#829) - fixing makefile rules for linter-tools (golangci-lint, errcheck, staticcheck) - removed unused gomock tool * PWX-33069: Upgrading golang to 1.20.7 (#1215) - also updating linter-tools and integration-tests * add missing /vendor dirs Manually fixed Conflicts: Makefile go.mod go.sum vendor/github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1/prometheus_types.go vendor/modules.txt Signed-off-by: Zoran Rajic <zox@portworx.com>
What this PR does / why we need it:
We're changing golang-compiler version
1.19.1->1.20.7
Note, there was a drastic reduction of
vendor/
-filesgithub.com/golangci/golangci-lint@v1.50.1
code-dependencygolangci-lint
binary - so we don't need to "keep the sources of the tool"Which issue(s) this PR fixes (optional)
Closes # PWX-33069
Special notes for your reviewer: