PWX-33069_23.7.0: upgrading golang and tools (#829) (#1215) (#1227) #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixing makefile rules for linter-tools (golangci-lint, errcheck, staticcheck) * removed unused gomock tool Signed-off-by: Zoran Rajic <zrajic@purestorage.com>
* also updating linter-tools and integration-tests Signed-off-by: Zoran Rajic <zox@portworx.com> Manually fixed Conflicts: Makefile go.mod go.sum vendor/github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1/prometheus_types.go vendor/modules.txt
zoxpx
changed the title
|
These commits are cherry-picked from |
|
Security scan @ https://aetos.pwx.purestorage.com/security/Operator/23-7-0-DEV/2023-08-24-10-15-33-342757
Jenkins test @ https://jenkins.pwx.dev.purestorage.com/job/Operator/view/Operator%20Release%20Dashboard/job/op-basic-hotfix/33
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Makefiles to use
golangci-lintas standalone toolUpgrading golang to 1.20.7
Signed-off-by: Zoran Rajic zox@portworx.com
What this PR does / why we need it:
This is a cherry-pick of #1215 into
px-rel-23.7.0branchWhich issue(s) this PR fixes (optional)
Closes # PWX-33069
Special notes for your reviewer: