Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-29422: Providing option to specify namespaces selector in migrati… #1395

Merged
merged 3 commits into from
May 11, 2023

Conversation

pp511
Copy link
Contributor

@pp511 pp511 commented May 4, 2023

…on spec.

What type of PR is this?

feature

What this PR does / why we need it:
https://portworx.atlassian.net/browse/PWX-29422
Allow users to specify namespace selectors in migration spec.

Does this PR change a user-facing CRD or CLI?:
yes,

Is a release note needed?:
Yes

  • You can now provide namespace labels in MigrationSchedule spec to specify namespaces for migration.

Does this change need to be cherry-picked to a release branch?:
yes 23.5.0

Notes:

  • I have added one function getMigrationNamespaces to get all unique namespaces for migration and referencing this list throughout our migration flow.
MigrationSchedule ->
spec:
 template:
   spec:
       namespaceSelectors:
         ns: migrate

Namespace ->
kind: Namespace
metadata:
 labels:
   kubernetes.io/metadata.name: mysql
   ns: migrate

@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@pp511 pp511 changed the title PWX-29422: Providing option to specify namespaces selector in migrati… PWX-29422: Providing option to specify namespaces selector in migrati… [Draft - Do not merge] May 4, 2023
@pp511 pp511 changed the title PWX-29422: Providing option to specify namespaces selector in migrati… [Draft - Do not merge] PWX-29422: Providing option to specify namespaces selector in migrati… May 5, 2023
…on spec.

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.20 🎉

Comparison is base (cfb3d6d) 67.76% compared to head (abb3c3d) 67.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
+ Coverage   67.76%   67.96%   +0.20%     
==========================================
  Files          42       42              
  Lines        4889     4939      +50     
==========================================
+ Hits         3313     3357      +44     
- Misses       1242     1245       +3     
- Partials      334      337       +3     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
@pp511 pp511 merged commit 09eb6ad into master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants