-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for control over TCP socket #24
Comments
oh... i just kind of realized the fundamental incompatibility with unix sockets and multiaddr... |
Well, we don't need to dial, we need to listen. But yeah, for testing purposes agreed that this could be useful. |
Does the multiaddr spec define a strategy to deal with values containing slashes? |
@vyzo for incoming streams the daemon needs to dial as well, no? To deliver that steam to the app. Also there was a case in pubsub/DHT with validators? |
yeah @raulk that was my thinking |
I think this may have been implemented now? At least the tests have been? |
Yes, this has been implemented; closing. |
In order to leverage the daemon for purposes of integration testing and the testbed more generally, we need to have remote-dialable daemons. I'd vote for abstracting the listen path into a multiaddr (similarly, client listen paths should be multiaddrs) and adding support to dial unix sockets to go-multiaddr-net.
The text was updated successfully, but these errors were encountered: