Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for control over TCP socket #24

Closed
bigs opened this issue Nov 16, 2018 · 7 comments
Closed

Allow for control over TCP socket #24

bigs opened this issue Nov 16, 2018 · 7 comments

Comments

@bigs
Copy link
Contributor

bigs commented Nov 16, 2018

In order to leverage the daemon for purposes of integration testing and the testbed more generally, we need to have remote-dialable daemons. I'd vote for abstracting the listen path into a multiaddr (similarly, client listen paths should be multiaddrs) and adding support to dial unix sockets to go-multiaddr-net.

@bigs
Copy link
Contributor Author

bigs commented Nov 16, 2018

oh... i just kind of realized the fundamental incompatibility with unix sockets and multiaddr...

@vyzo
Copy link
Collaborator

vyzo commented Nov 16, 2018

Well, we don't need to dial, we need to listen.

But yeah, for testing purposes agreed that this could be useful.

@raulk
Copy link
Member

raulk commented Nov 16, 2018

Does the multiaddr spec define a strategy to deal with values containing slashes?

@raulk
Copy link
Member

raulk commented Nov 16, 2018

@vyzo for incoming streams the daemon needs to dial as well, no? To deliver that steam to the app. Also there was a case in pubsub/DHT with validators?

@bigs
Copy link
Contributor Author

bigs commented Nov 16, 2018

yeah @raulk that was my thinking

@anacrolix
Copy link
Contributor

I think this may have been implemented now? At least the tests have been?

@vyzo
Copy link
Collaborator

vyzo commented Feb 11, 2019

Yes, this has been implemented; closing.

@vyzo vyzo closed this as completed Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants