Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only do bucket refreshes on buckets that are likely to have peers #551

Closed
aschmahmann opened this issue Apr 6, 2020 · 1 comment
Closed

Comments

@aschmahmann
Copy link
Contributor

Currently (in the cypress DHT branch) we refresh up until the bucket with the common prefix length of the peer in our routing table with the most shared bits with us. This could be a problem, as described in libp2p/go-libp2p-kbucket#71 (comment), because we could get unlucky and end up querying way more buckets then is reasonable for our network size.

This is currently not an issue because due to issues with our DHT RPCs we cannot query an arbitrary KadID to fill our buckets and so we have precalculated random ID prefixes for the first 15 buckets, and therefore will only query at most 15 buckets.

Once this issue is fixed and the limit of refreshing the first 15 buckets is dropped we could run into problems.

@aschmahmann
Copy link
Contributor Author

@Stebalien beat me to it with #550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant