Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/crypto (openssl): RSA public key generation broken #1951

Closed
marten-seemann opened this issue Dec 13, 2022 · 0 comments · Fixed by #1953
Closed

core/crypto (openssl): RSA public key generation broken #1951

marten-seemann opened this issue Dec 13, 2022 · 0 comments · Fixed by #1953
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor

This is probably not the right way to export a public key:

return &RsaPrivateKey{opensslPrivateKey{key}}, &RsaPublicKey{opensslPublicKey{key: key}}, nil

return &RsaPublicKey{opensslPublicKey{key: sk.opensslPrivateKey.key}}

As far as I can see, the fix would need to happen in go-openssl, and involve a bunch of super-ugly Go-to-C and vice versa code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant