Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libp2p.New docs say to stop/shutdown cancel the passed in context, but there is no ctx. #2773

Closed
zeisler opened this issue Apr 18, 2024 · 0 comments · Fixed by #2775
Closed

Comments

@zeisler
Copy link

zeisler commented Apr 18, 2024

Location

func New

Description

Current Docs:

 To stop/shutdown the returned libp2p node, the user needs to cancel the passed context and call `Close` on the returned Host.

There is no longer a passed in context it was removed here #1190

I would just create a PR to fix the docs but I'm unsure if there is additional process for passing in a context or if there is another way to shutdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant