Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable write coalescing #27

Open
jacobheun opened this issue Apr 20, 2020 · 1 comment
Open

Re-enable write coalescing #27

jacobheun opened this issue Apr 20, 2020 · 1 comment

Comments

@jacobheun
Copy link

Write coalescing was disabled in #24 due to some downstream issues. We need to add more testing, including benchmarks around write coalescing so that we can confidently reenable it.

Success Criteria

  • Write coalescing is well tested and benchmarked
  • Write coalescing is enabled
@willscott
Copy link
Contributor

ℹ️ Benchmarks can probably be (largely) shared with the go-mplex alternative. Even in that implementation of write-coalescing it's looking like the mechanism is having a performance impact. Ref: libp2p/go-mplex#77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants