Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork scheduled workfows #93

Closed
jschueller opened this issue Oct 1, 2023 · 7 comments
Closed

fork scheduled workfows #93

jschueller opened this issue Oct 1, 2023 · 7 comments

Comments

@jschueller
Copy link
Collaborator

each fork of prima runs scheduled workflows on its own, thats unnecessary and may slow users own workflows

this is a known issue
https://github.com/orgs/community/discussions/16109

the solution would be adding a condition for each job:
if: github.repository == 'libprima/prima'

@zaikunzhang
Copy link
Member

zaikunzhang commented Oct 8, 2023

Hi @jschueller ,

Apologies for the late response.

I agree that it is an issue. It would be desirable if there was a systematic way to specify the repo where a workflow should run. However, doing it on the job level seems not ideal.

The solution I suggest for the moment is to disable the workflow manually.

Also, I would like to remark that all workflows with a cron schedule are disabled by default on forks according to GitHub's documentation:

Warning: To prevent unnecessary workflow runs, scheduled workflows may be disabled automatically. When a public repository is forked, scheduled workflows are disabled by default. 

@jschueller
Copy link
Collaborator Author

sorry, but that's not what I experienced on my fork: scheduled workflows ran there too slowing down my own jobs from my other repos

@zaikunzhang
Copy link
Member

sorry, but that's not what I experienced on my fork: scheduled workflows ran there too slowing down my own jobs from my other repos

There is probably a bug on the GitHub side. I also experienced that some scheduled workflows are enabled unintendedly, but I cannot reproduce the problem. If you can, you may report to GitHub.

For the moment, the solution is to disable the workflows manually.

Thank you.

@jschueller
Copy link
Collaborator Author

the issue has been reported:
https://github.com/orgs/community/discussions/16109
the solution is to explicitely disable it via a job condition:
#94

@zaikunzhang
Copy link
Member

zaikunzhang commented Oct 8, 2023

I guess it had been reported before GitHub implemented "disable scheduled workflows on forks by default".

The (new) problem is that the implementation seems not always working.

Thanks.

@jschueller
Copy link
Collaborator Author

seems its disabled now on new forks

@zaikunzhang
Copy link
Member

Great. Thanks.

I still observe from time to time that they are enabled on some forks. But I have not recognized the pattern yet. So do not be surprised if they come back ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants