[FBW] Avoid duplicated donwloads, create networks and get hostname #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarcos87
requested review from
nicopace and
G10h4ck
and removed request for
nicopace
nicoechaniz
approved these changes
Apr 21, 2019
spiccinini
approved these changes
Apr 21, 2019
G10h4ck
reviewed
Apr 21, 2019
packages/first-boot-wizard/files/usr/lib/lua/firstbootwizard.lua
Outdated
Show resolved
Hide resolved
G10h4ck
reviewed
Apr 21, 2019
| -- Start sharing lime-defaults and reboot | ||
| share_defualts() | ||
| remove_lock_file() | ||
| os.execute("reboot 0") |
There was a problem hiding this comment.
fix typo in 50582c1
G10h4ck
reviewed
Apr 21, 2019
packages/ubus-lime-fbw/Makefile
Outdated
| @@ -25,6 +25,7 @@ define Package/$(PKG_NAME)/install | |||
| $(CP) ./files/* $(1)/ | |||
| @chmod a+x $(1)/usr/libexec/daemon/lime-fbw | |||
| @chmod a+x $(1)/etc/init.d/ubus-lime-fbw | |||
| @chmod a+x $(1)/www/cgi-bin/hostname | |||
There was a problem hiding this comment.
AFAIR some makefile macro should be used instead con plain chmod to install executables @spiccinini do you remember if it is like that?
There was a problem hiding this comment.
Yes, INSTALL_BIN macro does chmod +x (equivalent to chdmo a+x)
There was a problem hiding this comment.
This package is using "the trick" using CP ./files/* so using INSTALL_* macros goes against that practicity. I don't know if there is a preferred way. I see mixed uses in other packages (from openwrt and libremesh).
G10h4ck
reviewed
Apr 21, 2019
G10h4ck
reviewed
Apr 21, 2019
packages/first-boot-wizard/files/usr/lib/lua/firstbootwizard/utils.lua
Outdated
Show resolved
Hide resolved
|
This fixes #101 ? |
|
yes @spiccinini close #101 |
G10h4ck
requested changes
Apr 22, 2019
packages/first-boot-wizard/files/usr/lib/lua/firstbootwizard/utils.lua
Outdated
Show resolved
Hide resolved
G10h4ck
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid duplicated downloads
Before it downloaded all the configurations from the associated devices each time it configured the network. Now it does it once per mac address.
Get remote hostname
Obtains the remote hostname the moment it gets the configurations and saves the data in the file.
Set username in create and join network functions
The user can input a hostname so that it changes the moment the new network configuration is set.