Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pirania rcpd api fixes and improvements #892

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

spiccinini
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #892 (502af53) into master (55ec0b8) will increase coverage by 0.62%.
The diff coverage is 98.71%.

❗ Current head 502af53 differs from pull request most recent head 0cfc828. Consider uploading reports for the commit 0cfc828 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
+ Coverage   73.92%   74.54%   +0.62%     
==========================================
  Files          41       43       +2     
  Lines        3559     3658      +99     
==========================================
+ Hits         2631     2727      +96     
- Misses        928      931       +3     
Impacted Files Coverage Δ
...kages/lime-system/files/usr/lib/lua/lime/utils.lua 81.06% <75.00%> (+0.82%) ⬆️
packages/pirania/tests/pirania_test_utils.lua 100.00% <100.00%> (ø)
...-network_nodes/files/usr/lib/lua/network-nodes.lua 100.00% <100.00%> (ø)
...es/shared-state/files/usr/lib/lua/shared-state.lua 77.23% <0.00%> (+0.44%) ⬆️
...ges/pirania/files/usr/lib/lua/voucher/vouchera.lua 53.23% <0.00%> (+0.57%) ⬆️
...ckages/pirania/files/usr/lib/lua/voucher/store.lua 96.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ec0b8...0cfc828. Read the comment docs.

Copy link
Contributor

@germanferrero germanferrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spiccinini Thanks!

I had this comment about how testing of rpcd code is being done in which I proposed you to assert on lua module's add voucher method being called with the correct parameters.

But I understand that it's agile to merge this PR and change test-strategy along with the other needed changes for pirania backend.

@spiccinini
Copy link
Contributor Author

Thanks ger for the feedback!

@spiccinini spiccinini merged commit 58bb697 into libremesh:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants