Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/split lime utils logic #939

Merged
merged 4 commits into from
Nov 28, 2022

Conversation

selankon
Copy link
Collaborator

  • Move all logic outside the rpcd

@ilario
Copy link
Member

ilario commented Oct 21, 2022

This is great!
But we are also planning to, some day, split lime.utils from lime-system, see #771

And it will be confusing if we will have:

  • lime.utils packaged in a future lime-utils package and located at /usr/lib/lua/lime/utils.lua

and

  • lime-utils packaged in ubus-lime-utils and located at /usr/lib/lua/lime-utils.lua

This is already represented by the fact that lime-utils.lua is importing lime.utils:

What do you think about naming these new files including the ubus- prefix?

Oooooor, alternatively, the new lime-utils.lua file could also include the functions from the lime-system's lime.utils. On this regard, I have a question dictated by ignorance: what is the difference from the utils included in ubus-lime-utils and in lime-system's lime.utils?

@spiccinini
Copy link
Contributor

+1 to Illario's comment, I think this PR is a step required to splitting this functionality and lime.utils in its own package. For me lets merge this and address it in other PR

@ilario
Copy link
Member

ilario commented Oct 25, 2022

+1 to Illario's comment, I think this PR is a step required to splitting this functionality and lime.utils in its own package. For me lets merge this and address it in other PR

Mh? What do you mean?
Are we going to merge ubus-lime-utils with the lime-utils from lime-system?

@G10h4ck G10h4ck merged commit 40bd93c into libremesh:master Nov 28, 2022
@G10h4ck G10h4ck added this to the mesh-wide milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants