Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/lime utils issue #962 #963

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

selankon
Copy link
Collaborator

This should fix #962 . This fix some errors after #939

@codecov-commenter
Copy link

Codecov Report

Merging #963 (3d23b6d) into master (c9aa653) will increase coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
+ Coverage   77.72%   77.73%   +0.01%     
==========================================
  Files          52       52              
  Lines        4359     4362       +3     
==========================================
+ Hits         3388     3391       +3     
  Misses        971      971              
Impacted Files Coverage Δ
...s/ubus-lime-utils/files/usr/lib/lua/lime-utils.lua 33.87% <60.00%> (+1.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ilario
Copy link
Member

ilario commented Dec 27, 2022

I am going to approve this even without testing as @selankon is editing their own edits from a previous PR.

@ilario ilario self-requested a review December 27, 2022 13:36
@ilario
Copy link
Member

ilario commented Jan 18, 2023

I am not able to test this (sorry @selankon) but merging as you are modifying your own code and I suppose you tested it.

@ilario ilario merged commit 823d07e into libremesh:master Jan 18, 2023
@G10h4ck G10h4ck added this to the mesh-wide milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lime utils broken if associated ap's
4 participants