refactor: Default to only using mysqli (#4915)

* refactor: Default to only using mysqli

* Remove includes/dbFacile.mysql.php

* updated mres() function to remove $config global

config.php.default

@@ -7,7 +7,6 @@ $config['db_host'] = 'localhost';
 $config['db_user'] = 'USERNAME';
 $config['db_pass'] = 'PASSWORD';
 $config['db_name'] = 'librenms';
-$config['db']['extension'] = 'mysqli';// mysql or mysqli
 
 // This is the user LibreNMS will run as
 //Please ensure this user is created and has the correct permissions to your install

doc/Support/Configuration.md

@@ -31,12 +31,6 @@ $config['db_pass'] = '';
 $config['db_name'] = '';
 ```
 
-You can also select between the mysql and mysqli php extensions:
-
-```php
-$config['db']['extension'] = 'mysqli';
-```
-
 #### Programs
 
 A lot of these are self explanatory so no further information may be provided. Any extensions that have dedicated 

html/install.php

@@ -38,7 +38,7 @@
 }
 
 require '../includes/defaults.inc.php';
-$config['db']['extension']='mysqli';
+
 // Work out the install directory
 $cur_dir = explode('/', __DIR__);
 $check = end($cur_dir);
@@ -304,11 +304,10 @@
          <h5 class="text-center">Importing MySQL DB - Do not close this page or interrupt the import</h5>
 <?php
 // Ok now let's set the db connection up
-    $config['db_host']=$dbhost;
-    $config['db_user']=$dbuser;
-    $config['db_pass']=$dbpass;
-    $config['db_name']=$dbname;
-    $config['db']['extension']='mysqli';
+    $config['db_host'] = $dbhost;
+    $config['db_user'] = $dbuser;
+    $config['db_pass'] = $dbpass;
+    $config['db_name'] = $dbname;
     $sql_file = '../build.sql';
     $_SESSION['last'] = time();
     ob_end_flush();

includes/common.php

@@ -397,12 +397,8 @@ function truncate($substring, $max = 50, $rep = '...')
 function mres($string)
 {
     // short function wrapper because the real one is stupidly long and ugly. aesthetics.
-    global $config, $database_link;
-    if ($config['db']['extension'] == 'mysqli') {
-        return mysqli_real_escape_string($database_link, $string);
-    } else {
-        return mysql_real_escape_string($string);
-    }
+    global $database_link;
+    return mysqli_real_escape_string($database_link, $string);
 }
 
 function getifhost($id)