Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding state sensor support for RFC1628 UPS #6153

Merged
merged 4 commits into from Mar 12, 2017
Merged

fix: Adding state sensor support for RFC1628 UPS #6153

merged 4 commits into from Mar 12, 2017

Conversation

ghost
Copy link

@ghost ghost commented Mar 9, 2017

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


screen shot 2017-03-09 at 13 23 54
screen shot 2017-03-09 at 13 22 36

  • Adding two state sensors for RFC1628 using the new format (based on the RFC it's a single OID, don't need to get multiple).
  • Removed the two precedent informations that were not a sensor (Estimated minutes remaining & Minutes on Battery) because I don't know where to put this information, no category for these kind of graphs.

Details: #5977

@mention-bot
Copy link

Thank you for submitting a PR @FTBZ! We have found the following @laf and @einhirn based on the history of these files to review this PR.

@ghost ghost changed the title Adding state sensor support for RFC1628 UPS fix: Adding state sensor support for RFC1628 UPS Mar 9, 2017
@laf
Copy link
Member

laf commented Mar 11, 2017

Thanks for this @FTBZ .

One of the removed items is runtime so I've recreated that.

If you don't mind pulling that change in and testing it that would be ace.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6153.ci.librenms.org or https://6153.ci.librenms.org

@ghost
Copy link
Author

ghost commented Mar 12, 2017

@laf, @murrant has create the runtime support in the PR #6158.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6153.ci.librenms.org or https://6153.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: 2 new issues

@murrant murrant merged commit 9c43fbd into librenms:master Mar 12, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants