New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding state sensor support for RFC1628 UPS #6153

Merged
merged 4 commits into from Mar 12, 2017

Conversation

Projects
None yet
6 participants
@FTBZ
Contributor

FTBZ commented Mar 9, 2017

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


screen shot 2017-03-09 at 13 23 54
screen shot 2017-03-09 at 13 22 36

  • Adding two state sensors for RFC1628 using the new format (based on the RFC it's a single OID, don't need to get multiple).
  • Removed the two precedent informations that were not a sensor (Estimated minutes remaining & Minutes on Battery) because I don't know where to put this information, no category for these kind of graphs.

Details: #5977

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 9, 2017

Thank you for submitting a PR @FTBZ! We have found the following @laf and @einhirn based on the history of these files to review this PR.

mention-bot commented Mar 9, 2017

Thank you for submitting a PR @FTBZ! We have found the following @laf and @einhirn based on the history of these files to review this PR.

@FTBZ FTBZ changed the title from Adding state sensor support for RFC1628 UPS to fix: Adding state sensor support for RFC1628 UPS Mar 9, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Mar 11, 2017

Member

Thanks for this @FTBZ .

One of the removed items is runtime so I've recreated that.

If you don't mind pulling that change in and testing it that would be ace.

Member

laf commented Mar 11, 2017

Thanks for this @FTBZ .

One of the removed items is runtime so I've recreated that.

If you don't mind pulling that change in and testing it that would be ace.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 11, 2017

Auto-Deploy finished, Test PR at http://6153.ci.librenms.org or https://6153.ci.librenms.org

@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ Mar 12, 2017

Contributor

@laf, @murrant has create the runtime support in the PR #6158.

Contributor

FTBZ commented Mar 12, 2017

@laf, @murrant has create the runtime support in the PR #6158.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Mar 12, 2017

Auto-Deploy finished, Test PR at http://6153.ci.librenms.org or https://6153.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Mar 12, 2017

The inspection completed: 2 new issues

scrutinizer-notifier commented Mar 12, 2017

The inspection completed: 2 new issues

@murrant murrant merged commit 9c43fbd into librenms:master Mar 12, 2017

2 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment