Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device: add suspended state to PAN OS #8125

Merged
merged 2 commits into from Jan 25, 2018
Merged

device: add suspended state to PAN OS #8125

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f2899
device: add suspended state to PAN OS
0-skill Jan 22, 2018
c570655
remove bad rules, solution in other PR
0-skill Jan 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion includes/definitions/discovery/panos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@ modules:
states:
- { value: 1, generic: 0, graph: 1, descr: active }
- { value: 2, generic: 3, graph: 1, descr: passive }
- { value: 3, generic: 2, graph: 1, descr: suspended }
-
oid: panSysHAPeerState
num_oid: .1.3.6.1.4.1.25461.2.1.2.1.12.
index: 'panSysHAPeerState.{{ $index }}'
descr: High Availability Peer Status
states:
- { value: 1, generic: 0, graph: 1, descr: active }
- { value: 2, generic: 3, graph: 1, descr: passive }
- { value: 2, generic: 3, graph: 1, descr: passive }
- { value: 3, generic: 2, graph: 1, descr: suspended }
4 changes: 0 additions & 4 deletions misc/alert_rules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,6 @@
"rule": "%devices.os = \"nxos\" && %sensors.sensor_type = \"cefcFanTrayOperStatus\" && %sensors.sensor_current = \"[3-4]\"",
"name": "Cisco NX-OS device has a bad fan"
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this was removed, it should be valid still as it checks that the previous state was passive but is not active.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule was tested in deep yesterday and no way to match it and I didn't find a way to make it work. Don't understand why but since this is an important one I prefer to remove it to prevent users from using it if it's not working.

"rule": "%devices.os = \"panos\" & %sensors.type = \"panSysHAState\" && %sensors.sensor_current = \"1\" && %sensors.sensor_prev = \"2\"",
"name": "Palo Alto Networks passive firewall changed to active"
},
{
"rule": "%sensors.sensor_current ~ \"[2|6]\" && %sensors.sensor_oid = \".1.3.6.1.4.1.674.10893.1.20.130.15.1.4.1\"",
"name": "Dell Server Raid Battery Failed/Degraded"
Expand Down