Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontAwesome icons bundled in openpdf #5

Closed
santeriv opened this issue Dec 10, 2016 · 4 comments
Closed

FontAwesome icons bundled in openpdf #5

santeriv opened this issue Dec 10, 2016 · 4 comments

Comments

@santeriv
Copy link

Hi I got this idea from Vaadin:

Could FontAwesome icons be also added similar way to openpdf?

https://github.com/vaadin/framework/blob/7.7/scripts/generateFontAwesomeEnum.sh
https://github.com/vaadin/framework/blob/7.7/server/src/main/java/com/vaadin/server/FontAwesome.java
https://github.com/vaadin/framework/blob/7.7/server/src/main/java/com/vaadin/server/FontAwesome.java#L773
https://github.com/vaadin/framework/blob/7.7/server/src/main/java/com/vaadin/server/GenericFontIcon.java#L94

So if openpdf supports html evaluation this should be doable?

I've used some years ago commercial one (iText) with xhtml,css pipelines but don't know how exactly html is converted to pdf with openpdf if it is possible?

ref: http://fontawesome.io/

@ghost
Copy link

ghost commented Dec 10, 2016

This is a good idea. Perhaps you could submit a pull request?

@santeriv
Copy link
Author

Thanks for quick response. I'd like to do it unless you are already holding your breath. Might take a week or so to find a gap. :)

@ghost ghost added the enhancement label Jan 30, 2017
@bengolder
Copy link
Collaborator

@santeriv did you ever take a shot at this? Should we keep this issue open for further discussion?

@santeriv
Copy link
Author

@bengolder good that you asked. I overestimated my available time. I did test the .sh script it seems to be a good base yet I felt a bit unsure whether this was doable at all. Thus, this issue can remain Open.

@ghost ghost closed this as completed Feb 2, 2017
andreasrosdal pushed a commit that referenced this issue Jan 16, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants